Sync from kubeflow/model-registry 6e18d5a#7348
Sync from kubeflow/model-registry 6e18d5a#7348openshift-merge-bot[bot] merged 14 commits intoopendatahub-io:mainfrom
Conversation
…d3a13a35696a99de0a9a (no file changes)
…efe6ed71c66501040138 (no file changes)
…01c897705123b81c87f0 (no file changes)
…cf23aaa496282231cd6a (no file changes)
…1299cd18b8faf52e8633 (no file changes)
…e424f4b0e1a7821937a3 (no file changes)
…3f5d6fe91aad6fd1b9e5 (no file changes)
…7b37ab42fafed7de733f (no file changes)
…ng for MCP (opendatahub-io#2622) Upstream commit: 26e784c6d2aa4d25845be57567a7156fa4b37dce
…es (opendatahub-io#2526) Upstream commit: f953cc20feea8838fac24064d0a4201df7fe0e70
…om 0.35.3 to 0.35.4 in /clients/ui/bff (opendatahub-io#2614) Upstream commit: 19dc8e3fdbfc2a139d90a6eee0674b3b29f308f3
…ConfigMap to `default-catalog-sources` (opendatahub-io#2593) Upstream commit: f7b549fc9dd27eb0f3e4090c70c2bda2a16c6dba
…lug helper under Allowed organization (opendatahub-io#2600) Upstream commit: 6819f351f62bfc265679cb4f3a5720ba81746da1
…4ae581b9c42d0767aff7 (no file changes)
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited) Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (18)
📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdated the Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #7348 +/- ##
==========================================
- Coverage 65.04% 63.88% -1.16%
==========================================
Files 2458 2513 +55
Lines 76354 77909 +1555
Branches 19257 19801 +544
==========================================
+ Hits 49662 49776 +114
- Misses 26692 28133 +1441
... and 67 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: manaswinidas The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
d504657
into
opendatahub-io:main
Description
Changes synced:
kubeflow/hub#2622 — Fix independent filters scrolling for MCP
kubeflow/hub#2526 — Fix/catalog source error messages
kubeflow/hub#2614 — build(deps): bump k8s.io/api from 0.35.3 to 0.35.4
kubeflow/hub#2593 — Rename default catalog sources ConfigMap to default-catalog-sources
kubeflow/hub#2600 — Add Hugging Face organization slug helper under Allowed organization
No conflicts were encountered
How Has This Been Tested?
Tested by running backend, frontend and the federated MR package separately as described below, verifying existing behavior in the files this diff touches, and verifying the incoming changes.
Also ran unit tests: npm run test:unit
and ran type check: npm run test:type-check
(both in packages/model-registry/upstream/frontend)
Process to run everything locally this way:
Create .env.development.local and copy the contents of .env.development to it. Change the backend port to 4020 to avoid conflicts with the upstream running.
oc login to a cluster with ODH installed
Run both frontend and backend folders with npm run start:dev after running npm install on odh-dashboard root repository
Before continuing, install kubectl and golang
With these two terminal tabs open, open a third terminal tab, go to packages/model-registry/upstream and run make dev-install-dependencies followed by PORT=9100 make dev-start-federated INSECURE_SKIP_VERIFY=true
Test Impact
Upstream changes include their own tests.
Request review criteria:
Self checklist (all need to be checked):
If you have UI changes:
After the PR is posted & before it merges:
mainSummary by CodeRabbit