Skip to content

Sync from kubeflow/model-registry 6e18d5a#7348

Merged
openshift-merge-bot[bot] merged 14 commits intoopendatahub-io:mainfrom
ppadti:mr-sync-2026-04-22
Apr 22, 2026
Merged

Sync from kubeflow/model-registry 6e18d5a#7348
openshift-merge-bot[bot] merged 14 commits intoopendatahub-io:mainfrom
ppadti:mr-sync-2026-04-22

Conversation

@ppadti
Copy link
Copy Markdown
Contributor

@ppadti ppadti commented Apr 22, 2026

Description

Changes synced:

kubeflow/hub#2622 — Fix independent filters scrolling for MCP
kubeflow/hub#2526 — Fix/catalog source error messages
kubeflow/hub#2614 — build(deps): bump k8s.io/api from 0.35.3 to 0.35.4
kubeflow/hub#2593 — Rename default catalog sources ConfigMap to default-catalog-sources
kubeflow/hub#2600 — Add Hugging Face organization slug helper under Allowed organization
No conflicts were encountered

How Has This Been Tested?

Tested by running backend, frontend and the federated MR package separately as described below, verifying existing behavior in the files this diff touches, and verifying the incoming changes.

Also ran unit tests: npm run test:unit
and ran type check: npm run test:type-check
(both in packages/model-registry/upstream/frontend)

Process to run everything locally this way:

Create .env.development.local and copy the contents of .env.development to it. Change the backend port to 4020 to avoid conflicts with the upstream running.
oc login to a cluster with ODH installed
Run both frontend and backend folders with npm run start:dev after running npm install on odh-dashboard root repository
Before continuing, install kubectl and golang
With these two terminal tabs open, open a third terminal tab, go to packages/model-registry/upstream and run make dev-install-dependencies followed by PORT=9100 make dev-start-federated INSECURE_SKIP_VERIFY=true
Test Impact
Upstream changes include their own tests.

Request review criteria:

Self checklist (all need to be checked):

  • The developer has manually tested the changes and verified that the changes work
  • Testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has added tests or explained why testing cannot be added (unit or cypress tests for related changes)
  • The code follows our Best Practices (React coding standards, PatternFly usage, performance considerations)

If you have UI changes:

  • Included any necessary screenshots or gifs if it was a UI change.
  • Included tags to the UX team if it was a UI/UX change.

After the PR is posted & before it merges:

  • The developer has tested their solution on a cluster by using the image produced by the PR to main

Summary by CodeRabbit

  • Chores
    • Updated model-registry integration to the latest upstream version.

ppadti added 14 commits April 22, 2026 13:20
…ng for MCP (opendatahub-io#2622)

Upstream commit: 26e784c6d2aa4d25845be57567a7156fa4b37dce
…es (opendatahub-io#2526)

Upstream commit: f953cc20feea8838fac24064d0a4201df7fe0e70
…om 0.35.3 to 0.35.4 in /clients/ui/bff (opendatahub-io#2614)

Upstream commit: 19dc8e3fdbfc2a139d90a6eee0674b3b29f308f3
…ConfigMap to `default-catalog-sources` (opendatahub-io#2593)

Upstream commit: f7b549fc9dd27eb0f3e4090c70c2bda2a16c6dba
…lug helper under Allowed organization (opendatahub-io#2600)

Upstream commit: 6819f351f62bfc265679cb4f3a5720ba81746da1
@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented Apr 22, 2026

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository YAML (base), Central YAML (inherited), Organization UI (inherited)

Review profile: CHILL

Plan: Pro Plus

Run ID: 118a3a10-a33a-4106-9101-fbe3c3146dff

📥 Commits

Reviewing files that changed from the base of the PR and between 543bc78 and 24c5e14.

⛔ Files ignored due to path filters (18)
  • packages/model-registry/upstream/bff/go.mod is excluded by !**/upstream/**
  • packages/model-registry/upstream/bff/go.sum is excluded by !**/*.sum, !**/upstream/**, !**/*.sum
  • packages/model-registry/upstream/bff/internal/integrations/kubernetes/client.go is excluded by !**/upstream/**
  • packages/model-registry/upstream/bff/internal/integrations/kubernetes/k8mocks/base_testenv.go is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/__tests__/cypress/cypress/pages/modelCatalogSettings.ts is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/__tests__/cypress/cypress/tests/mocked/modelCatalogSettings/modelCatalogSettings.cy.ts is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/mcpCatalog/screens/McpCatalog.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CatalogSourceStatus.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CatalogSourceStatusErrorModal.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CredentialsSection.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/ManageSourceForm.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/ManageSourceFormFooter.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/ModelVisibilitySection.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/PreviewPanel.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/YamlSection.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/__tests__/PreviewPanel.spec.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/constants.tsx is excluded by !**/upstream/**
  • packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/screens/CatalogSourceConfigsTableColumns.tsx is excluded by !**/upstream/**
📒 Files selected for processing (1)
  • packages/model-registry/package.json

📝 Walkthrough

Walkthrough

Updated the subtree.commit hash in packages/model-registry/package.json from d941024350a42ef5f0b047c4617ee98e85158e26 to 6e18d5aca6de378c66794ae581b9c42d0767aff7, referencing a different upstream kubeflow/model-registry revision. Single-line modification with no logic, API, or configuration changes.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Description check ⚠️ Warning The description documents synced upstream changes, testing performed, and local setup instructions. The self-checklist boxes remain unchecked despite testing claims, indicating incomplete fulfillment of documented review criteria. Complete the self-checklist by checking boxes that apply; at minimum, check the box for manual testing verification and explanation of why backend testing cannot be added if applicable.
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically references the synced commit hash from kubeflow/model-registry, directly matching the changeset which updates the subtree.commit value.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 22, 2026

Codecov Report

❌ Patch coverage is 20.00000% with 32 lines in your changes missing coverage. Please review.
✅ Project coverage is 63.88%. Comparing base (543bc78) to head (24c5e14).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...es/modelCatalogSettings/components/YamlSection.tsx 0.00% 18 Missing ⚠️
...alogSettings/components/ModelVisibilitySection.tsx 0.00% 5 Missing ⚠️
...lCatalogSettings/components/CredentialsSection.tsx 0.00% 4 Missing ⚠️
...s/modelCatalogSettings/components/PreviewPanel.tsx 0.00% 4 Missing ⚠️
...delCatalogSettings/components/ManageSourceForm.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7348      +/-   ##
==========================================
- Coverage   65.04%   63.88%   -1.16%     
==========================================
  Files        2458     2513      +55     
  Lines       76354    77909    +1555     
  Branches    19257    19801     +544     
==========================================
+ Hits        49662    49776     +114     
- Misses      26692    28133    +1441     
Files with missing lines Coverage Δ
...nd/src/app/pages/mcpCatalog/screens/McpCatalog.tsx 7.14% <ø> (ø)
...CatalogSettings/components/CatalogSourceStatus.tsx 3.57% <ø> (ø)
...tings/components/CatalogSourceStatusErrorModal.tsx 20.00% <ø> (ø)
...alogSettings/components/ManageSourceFormFooter.tsx 16.66% <ø> (ø)
...d/src/app/pages/modelCatalogSettings/constants.tsx 74.07% <100.00%> (+5.89%) ⬆️
...tings/screens/CatalogSourceConfigsTableColumns.tsx 10.00% <ø> (ø)
...delCatalogSettings/components/ManageSourceForm.tsx 2.32% <0.00%> (ø)
...lCatalogSettings/components/CredentialsSection.tsx 3.70% <0.00%> (-0.30%) ⬇️
...s/modelCatalogSettings/components/PreviewPanel.tsx 2.70% <0.00%> (-0.08%) ⬇️
...alogSettings/components/ModelVisibilitySection.tsx 5.88% <0.00%> (+1.12%) ⬆️
... and 1 more

... and 67 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 543bc78...24c5e14. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@manaswinidas manaswinidas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@openshift-ci
Copy link
Copy Markdown
Contributor

openshift-ci Bot commented Apr 22, 2026

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: manaswinidas

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot Bot merged commit d504657 into opendatahub-io:main Apr 22, 2026
97 of 99 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants