From 72fd93408ae328c2922cdf7cec1bbed4ab96940f Mon Sep 17 00:00:00 2001 From: ppadti Date: Wed, 22 Apr 2026 13:20:46 +0530 Subject: [PATCH 01/14] Update @odh-dashboard/model-registry tracking to 2ed730b8c636640add1cd3a13a35696a99de0a9a (no file changes) --- packages/model-registry/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/model-registry/package.json b/packages/model-registry/package.json index dd0fe0cd98..18836f604a 100644 --- a/packages/model-registry/package.json +++ b/packages/model-registry/package.json @@ -23,7 +23,7 @@ "branch": "main", "src": "clients/ui", "target": "upstream", - "commit": "d941024350a42ef5f0b047c4617ee98e85158e26" + "commit": "2ed730b8c636640add1cd3a13a35696a99de0a9a" }, "module-federation": { "name": "modelRegistry", From 68908144f45a1735e228695fd16fe585b724cb63 Mon Sep 17 00:00:00 2001 From: ppadti Date: Wed, 22 Apr 2026 13:20:46 +0530 Subject: [PATCH 02/14] Update @odh-dashboard/model-registry tracking to 12d13435a90483b9bdc7efe6ed71c66501040138 (no file changes) --- packages/model-registry/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/model-registry/package.json b/packages/model-registry/package.json index 18836f604a..f388ede71e 100644 --- a/packages/model-registry/package.json +++ b/packages/model-registry/package.json @@ -23,7 +23,7 @@ "branch": "main", "src": "clients/ui", "target": "upstream", - "commit": "2ed730b8c636640add1cd3a13a35696a99de0a9a" + "commit": "12d13435a90483b9bdc7efe6ed71c66501040138" }, "module-federation": { "name": "modelRegistry", From a640d985e7d7f58ba912fe12a42d6e0184a11540 Mon Sep 17 00:00:00 2001 From: ppadti Date: Wed, 22 Apr 2026 13:20:46 +0530 Subject: [PATCH 03/14] Update @odh-dashboard/model-registry tracking to 93d56023d5c252102d4301c897705123b81c87f0 (no file changes) --- packages/model-registry/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/model-registry/package.json b/packages/model-registry/package.json index f388ede71e..c7ea5181a4 100644 --- a/packages/model-registry/package.json +++ b/packages/model-registry/package.json @@ -23,7 +23,7 @@ "branch": "main", "src": "clients/ui", "target": "upstream", - "commit": "12d13435a90483b9bdc7efe6ed71c66501040138" + "commit": "93d56023d5c252102d4301c897705123b81c87f0" }, "module-federation": { "name": "modelRegistry", From 990fdfd4f085185894cc0bd592ce002c492b7bae Mon Sep 17 00:00:00 2001 From: ppadti Date: Wed, 22 Apr 2026 13:20:47 +0530 Subject: [PATCH 04/14] Update @odh-dashboard/model-registry tracking to de0edc74fb35342abefecf23aaa496282231cd6a (no file changes) --- packages/model-registry/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/model-registry/package.json b/packages/model-registry/package.json index c7ea5181a4..9061f8fb53 100644 --- a/packages/model-registry/package.json +++ b/packages/model-registry/package.json @@ -23,7 +23,7 @@ "branch": "main", "src": "clients/ui", "target": "upstream", - "commit": "93d56023d5c252102d4301c897705123b81c87f0" + "commit": "de0edc74fb35342abefecf23aaa496282231cd6a" }, "module-federation": { "name": "modelRegistry", From b0bbf468ef32e2ad314443f1e665d3a1e9865356 Mon Sep 17 00:00:00 2001 From: ppadti Date: Wed, 22 Apr 2026 13:20:47 +0530 Subject: [PATCH 05/14] Update @odh-dashboard/model-registry tracking to 43716b7a323974703dc21299cd18b8faf52e8633 (no file changes) --- packages/model-registry/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/model-registry/package.json b/packages/model-registry/package.json index 9061f8fb53..ac6afea4b5 100644 --- a/packages/model-registry/package.json +++ b/packages/model-registry/package.json @@ -23,7 +23,7 @@ "branch": "main", "src": "clients/ui", "target": "upstream", - "commit": "de0edc74fb35342abefecf23aaa496282231cd6a" + "commit": "43716b7a323974703dc21299cd18b8faf52e8633" }, "module-federation": { "name": "modelRegistry", From aae89b5eb20c49aded82706ce9fee0305aeb37ba Mon Sep 17 00:00:00 2001 From: ppadti Date: Wed, 22 Apr 2026 13:20:47 +0530 Subject: [PATCH 06/14] Update @odh-dashboard/model-registry tracking to 36dcfed0c566a5875aafe424f4b0e1a7821937a3 (no file changes) --- packages/model-registry/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/model-registry/package.json b/packages/model-registry/package.json index ac6afea4b5..fc88605f1e 100644 --- a/packages/model-registry/package.json +++ b/packages/model-registry/package.json @@ -23,7 +23,7 @@ "branch": "main", "src": "clients/ui", "target": "upstream", - "commit": "43716b7a323974703dc21299cd18b8faf52e8633" + "commit": "36dcfed0c566a5875aafe424f4b0e1a7821937a3" }, "module-federation": { "name": "modelRegistry", From 26dce9d4e849c63f3404add3b3fb3a6c4d791ee4 Mon Sep 17 00:00:00 2001 From: ppadti Date: Wed, 22 Apr 2026 13:20:47 +0530 Subject: [PATCH 07/14] Update @odh-dashboard/model-registry tracking to 7d27a9e9fa54fce37d8d3f5d6fe91aad6fd1b9e5 (no file changes) --- packages/model-registry/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/model-registry/package.json b/packages/model-registry/package.json index fc88605f1e..89a05e54f3 100644 --- a/packages/model-registry/package.json +++ b/packages/model-registry/package.json @@ -23,7 +23,7 @@ "branch": "main", "src": "clients/ui", "target": "upstream", - "commit": "36dcfed0c566a5875aafe424f4b0e1a7821937a3" + "commit": "7d27a9e9fa54fce37d8d3f5d6fe91aad6fd1b9e5" }, "module-federation": { "name": "modelRegistry", From f74beb8ec7e086518244c50d339927544f39a4e4 Mon Sep 17 00:00:00 2001 From: ppadti Date: Wed, 22 Apr 2026 13:20:47 +0530 Subject: [PATCH 08/14] Update @odh-dashboard/model-registry tracking to cb7de46b7f8e050fdb757b37ab42fafed7de733f (no file changes) --- packages/model-registry/package.json | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/packages/model-registry/package.json b/packages/model-registry/package.json index 89a05e54f3..0f19cbe293 100644 --- a/packages/model-registry/package.json +++ b/packages/model-registry/package.json @@ -23,7 +23,7 @@ "branch": "main", "src": "clients/ui", "target": "upstream", - "commit": "7d27a9e9fa54fce37d8d3f5d6fe91aad6fd1b9e5" + "commit": "cb7de46b7f8e050fdb757b37ab42fafed7de733f" }, "module-federation": { "name": "modelRegistry", From bf1e1330fe0da4b5c59e08c6a51a8106bcafb0d1 Mon Sep 17 00:00:00 2001 From: ppadti Date: Wed, 22 Apr 2026 13:20:47 +0530 Subject: [PATCH 09/14] Update @odh-dashboard/model-registry: Fix independent filters scrolling for MCP (#2622) Upstream commit: 26e784c6d2aa4d25845be57567a7156fa4b37dce --- packages/model-registry/package.json | 2 +- .../frontend/src/app/pages/mcpCatalog/screens/McpCatalog.tsx | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/model-registry/package.json b/packages/model-registry/package.json index 0f19cbe293..39ce9e5f42 100644 --- a/packages/model-registry/package.json +++ b/packages/model-registry/package.json @@ -23,7 +23,7 @@ "branch": "main", "src": "clients/ui", "target": "upstream", - "commit": "cb7de46b7f8e050fdb757b37ab42fafed7de733f" + "commit": "26e784c6d2aa4d25845be57567a7156fa4b37dce" }, "module-federation": { "name": "modelRegistry", diff --git a/packages/model-registry/upstream/frontend/src/app/pages/mcpCatalog/screens/McpCatalog.tsx b/packages/model-registry/upstream/frontend/src/app/pages/mcpCatalog/screens/McpCatalog.tsx index 4ca261136b..03f82235f9 100644 --- a/packages/model-registry/upstream/frontend/src/app/pages/mcpCatalog/screens/McpCatalog.tsx +++ b/packages/model-registry/upstream/frontend/src/app/pages/mcpCatalog/screens/McpCatalog.tsx @@ -46,7 +46,7 @@ const McpCatalog: React.FC = () => { provideChildrenPadding > - + From 344779a369854e19b2d56df3b1115563c44f93b0 Mon Sep 17 00:00:00 2001 From: ppadti Date: Wed, 22 Apr 2026 13:20:48 +0530 Subject: [PATCH 10/14] Update @odh-dashboard/model-registry: Fix/catalog source error messages (#2526) Upstream commit: f953cc20feea8838fac24064d0a4201df7fe0e70 --- packages/model-registry/package.json | 2 +- .../cypress/pages/modelCatalogSettings.ts | 2 +- .../modelCatalogSettings.cy.ts | 8 +- .../components/CatalogSourceStatus.tsx | 2 +- .../CatalogSourceStatusErrorModal.tsx | 6 +- .../components/CredentialsSection.tsx | 56 +++++++--- .../components/ManageSourceForm.tsx | 10 +- .../components/ManageSourceFormFooter.tsx | 3 +- .../components/ModelVisibilitySection.tsx | 96 +++++++++-------- .../components/PreviewPanel.tsx | 22 ++-- .../components/YamlSection.tsx | 102 +++++++++++------- .../__tests__/PreviewPanel.spec.tsx | 2 +- .../pages/modelCatalogSettings/constants.tsx | 70 +++++++++--- .../CatalogSourceConfigsTableColumns.tsx | 22 ++-- 14 files changed, 258 insertions(+), 145 deletions(-) diff --git a/packages/model-registry/package.json b/packages/model-registry/package.json index 39ce9e5f42..0a59d783e1 100644 --- a/packages/model-registry/package.json +++ b/packages/model-registry/package.json @@ -23,7 +23,7 @@ "branch": "main", "src": "clients/ui", "target": "upstream", - "commit": "26e784c6d2aa4d25845be57567a7156fa4b37dce" + "commit": "f953cc20feea8838fac24064d0a4201df7fe0e70" }, "module-federation": { "name": "modelRegistry", diff --git a/packages/model-registry/upstream/frontend/src/__tests__/cypress/cypress/pages/modelCatalogSettings.ts b/packages/model-registry/upstream/frontend/src/__tests__/cypress/cypress/pages/modelCatalogSettings.ts index 331e341e9c..434d299f04 100644 --- a/packages/model-registry/upstream/frontend/src/__tests__/cypress/cypress/pages/modelCatalogSettings.ts +++ b/packages/model-registry/upstream/frontend/src/__tests__/cypress/cypress/pages/modelCatalogSettings.ts @@ -97,7 +97,7 @@ class CatalogSourceConfigRow extends TableRow { return this; } - shouldHaveValidationStatus(status: 'Connected' | 'Failed' | 'Starting' | 'Unknown' | '-') { + shouldHaveValidationStatus(status: 'Ready' | 'Failed' | 'Starting' | 'Unknown' | '-') { this.findValidationStatus().contains(status); return this; } diff --git a/packages/model-registry/upstream/frontend/src/__tests__/cypress/cypress/tests/mocked/modelCatalogSettings/modelCatalogSettings.cy.ts b/packages/model-registry/upstream/frontend/src/__tests__/cypress/cypress/tests/mocked/modelCatalogSettings/modelCatalogSettings.cy.ts index 6daf05cce9..4097a8cb2d 100644 --- a/packages/model-registry/upstream/frontend/src/__tests__/cypress/cypress/tests/mocked/modelCatalogSettings/modelCatalogSettings.cy.ts +++ b/packages/model-registry/upstream/frontend/src/__tests__/cypress/cypress/tests/mocked/modelCatalogSettings/modelCatalogSettings.cy.ts @@ -443,7 +443,7 @@ describe('Catalog Source Configs Table', () => { modelCatalogSettings.visit(); const row = modelCatalogSettings.getRow('HuggingFace Google'); row.findName().should('be.visible'); - row.shouldHaveValidationStatus('Connected'); + row.shouldHaveValidationStatus('Ready'); row.findValidationStatus().findByTestId('source-status-connected-hf-google').should('exist'); }); @@ -783,7 +783,7 @@ describe('Manage Source Page', () => { // Before entering organization, should show generic text cy.contains( - 'Optionally filter which models from your source appear in the model catalog', + 'Optionally filter which models from this source appear in the model catalog', ).should('exist'); // Fill organization name @@ -791,7 +791,7 @@ describe('Manage Source Page', () => { // After entering organization, should show organization-specific text cy.contains( - 'Optionally filter which Google models from your source appear in the model catalog', + 'Optionally filter which Google models from this source appear in the model catalog', ).should('exist'); cy.contains('all Google models from the source will be visible').should('exist'); @@ -800,7 +800,7 @@ describe('Manage Source Page', () => { // Text should update to new organization cy.contains( - 'Optionally filter which Meta models from your source appear in the model catalog', + 'Optionally filter which Meta models from this source appear in the model catalog', ).should('exist'); cy.contains('all Meta models from the source will be visible').should('exist'); }); diff --git a/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CatalogSourceStatus.tsx b/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CatalogSourceStatus.tsx index 005c4257e2..afb1d181f6 100644 --- a/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CatalogSourceStatus.tsx +++ b/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CatalogSourceStatus.tsx @@ -54,7 +54,7 @@ const CatalogSourceStatus: React.FC = ({ catalogSource case CatalogSourceStatusEnum.AVAILABLE: return ( ); diff --git a/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CatalogSourceStatusErrorModal.tsx b/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CatalogSourceStatusErrorModal.tsx index 9cd19f945c..6b85582aa6 100644 --- a/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CatalogSourceStatusErrorModal.tsx +++ b/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CatalogSourceStatusErrorModal.tsx @@ -10,6 +10,7 @@ import { ModalVariant, } from '@patternfly/react-core'; import { ExclamationCircleIcon } from '@patternfly/react-icons'; +import { ERROR_MESSAGES } from '~/app/pages/modelCatalogSettings/constants'; type CatalogSourceStatusErrorModalProps = { isOpen: boolean; @@ -45,12 +46,11 @@ const CatalogSourceStatusErrorModal: React.FC

- The system cannot establish a connection to the source. Ensure that the organization is - accurate, then try again. + {ERROR_MESSAGES.VALIDATION_FAILED_BODY}

{errorMessage &&

{errorMessage}

} diff --git a/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CredentialsSection.tsx b/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CredentialsSection.tsx index 72f5a2e79b..b0f391bad4 100644 --- a/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CredentialsSection.tsx +++ b/packages/model-registry/upstream/frontend/src/app/pages/modelCatalogSettings/components/CredentialsSection.tsx @@ -1,6 +1,5 @@ import * as React from 'react'; import { - FormGroup, TextInput, FormHelperText, HelperText, @@ -12,7 +11,6 @@ import { } from '@patternfly/react-core'; import { UpdateObjectAtPropAndValue } from 'mod-arch-shared'; import PasswordInput from '~/app/shared/components/PasswordInput'; -import FormFieldset from '~/app/pages/modelRegistry/screens/components/FormFieldset'; import FormSection from '~/app/pages/modelRegistry/components/pf-overrides/FormSection'; import ThemeAwareFormGroupWrapper from '~/app/pages/settings/components/ThemeAwareFormGroupWrapper'; import { ManageSourceFormData } from '~/app/pages/modelCatalogSettings/useManageSourceData'; @@ -20,8 +18,11 @@ import { validateOrganization } from '~/app/pages/modelCatalogSettings/utils/val import { FORM_LABELS, VALIDATION_MESSAGES, - HELP_TEXT, + DESCRIPTION_TEXT, + HELPER_TEXT, PLACEHOLDERS, + ERROR_MESSAGES, + SUCCESS_MESSAGES, } from '~/app/pages/modelCatalogSettings/constants'; import { TempDevFeature, useTempDevFeatureAvailable } from '~/app/hooks/useTempDevFeatureAvailable'; @@ -67,7 +68,7 @@ const CredentialsSection: React.FC = ({ <> - {HELP_TEXT.ORGANIZATION} + {DESCRIPTION_TEXT.ORGANIZATION} @@ -111,18 +112,39 @@ const CredentialsSection: React.FC = ({ /> ); + const accessTokenDescriptionTxtNode = ( + + + {DESCRIPTION_TEXT.ACCESS_TOKEN} + + + ); + + const accessTokenHelperTxtNode = ( + + + {HELPER_TEXT.ACCESS_TOKEN} + + + ); + const accessTokenFormGroup = ( <> - - - - {HELP_TEXT.ACCESS_TOKEN} - - - - + + {accessTokenInput} + {validationError && ( - + {validationError.message} )} @@ -130,15 +152,15 @@ const CredentialsSection: React.FC = ({ } > - The organization and accessToken are valid for connection. + {SUCCESS_MESSAGES.VALIDATION_SUCCESSFUL_BODY} )} - +