Skip to content

Commit 8783a58

Browse files
emdnetolzchenxrmx
authored
introduce alls-green action for required checks (#4988)
* try alls-green for required checks Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * ci * add contrib_0 Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * test without allowed skips Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * simulate failure in public-symbols-check Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * empty commit to trigger ci -- added skip label -- ci check should pass * test single files Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * remove test_1.yml Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * update test.yml Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * test allowed-failures by job name Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * show alls-green check fails if one of the required jobs fail Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * remove uneeded files Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * cleanup Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * update README.md Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> * Apply suggestion from @xrmx * Apply suggestions from code review Co-authored-by: Emídio Neto <9735060+emdneto@users.noreply.github.com> --------- Signed-off-by: emdneto <9735060+emdneto@users.noreply.github.com> Co-authored-by: Leighton Chen <lechen@microsoft.com> Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com>
1 parent c932eb8 commit 8783a58

11 files changed

Lines changed: 2340 additions & 2344 deletions

File tree

.github/workflows/contrib.yml renamed to .github/workflows/ci.yml

Lines changed: 26 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,7 @@
1-
name: Core Contrib Test
1+
# Do not edit this file.
2+
# This file is generated automatically by executing tox -e generate-workflows
3+
4+
name: CI
25

36
on:
47
push:
@@ -14,12 +17,32 @@ concurrency:
1417
cancel-in-progress: true
1518

1619
jobs:
17-
contrib_0:
18-
uses: open-telemetry/opentelemetry-python-contrib/.github/workflows/core_contrib_test_0.yml@main
20+
misc:
21+
uses: ./.github/workflows/misc.yml
22+
lint:
23+
uses: ./.github/workflows/lint.yml
24+
tests:
25+
uses: ./.github/workflows/test.yml
26+
contrib:
27+
uses: open-telemetry/opentelemetry-python-contrib/.github/workflows/core_contrib_test.yml@main
1928
with:
2029
CORE_REPO_SHA: ${{ github.sha }}
2130
CONTRIB_REPO_SHA: ${{ github.event_name == 'pull_request' && (
2231
contains(github.event.pull_request.labels.*.name, 'prepare-release') && github.event.pull_request.head.ref ||
2332
contains(github.event.pull_request.labels.*.name, 'backport') && github.event.pull_request.base.ref ||
2433
'main'
2534
) || 'main' }}
35+
36+
check:
37+
if: always()
38+
needs:
39+
- misc
40+
- lint
41+
- tests
42+
- contrib
43+
runs-on: ubuntu-latest
44+
steps:
45+
- name: Decide whether the needed jobs succeeded or failed
46+
uses: re-actors/alls-green@release/v1
47+
with:
48+
jobs: ${{ toJSON(needs) }}

‎.github/workflows/generate_workflows.py‎

Lines changed: 27 additions & 22 deletions
Original file line numberDiff line numberDiff line change
@@ -140,29 +140,17 @@ def _generate_workflow(
140140
job_datas: list,
141141
template_name: str,
142142
output_dir: Path,
143-
max_jobs: int = 250,
144-
):
145-
# Github seems to limit the amount of jobs in a workflow file, that is why
146-
# they are split in groups of 250 per workflow file.
147-
for file_number, job_datas in enumerate(
148-
[
149-
job_datas[index : index + max_jobs]
150-
for index in range(0, len(job_datas), max_jobs)
151-
]
152-
):
153-
with open(
154-
output_dir.joinpath(f"{template_name}_{file_number}.yml"), "w"
155-
) as test_yml_file:
156-
test_yml_file.write(
157-
Environment(
158-
loader=FileSystemLoader(
159-
Path(__file__).parent.joinpath("templates")
160-
)
161-
)
162-
.get_template(f"{template_name}.yml.j2")
163-
.render(job_datas=job_datas, file_number=file_number)
143+
) -> None:
144+
env = Environment(
145+
loader=FileSystemLoader(Path(__file__).parent.joinpath("templates"))
146+
)
147+
with open(output_dir.joinpath(f"{template_name}.yml"), "w") as yml_file:
148+
yml_file.write(
149+
env.get_template(f"{template_name}.yml.j2").render(
150+
job_datas=job_datas,
164151
)
165-
test_yml_file.write("\n")
152+
)
153+
yml_file.write("\n")
166154

167155

168156
def generate_test_workflow(
@@ -197,6 +185,22 @@ def generate_misc_workflow(
197185
)
198186

199187

188+
def generate_ci_workflow(
189+
output_dir: Path,
190+
) -> None:
191+
with open(output_dir.joinpath("ci.yml"), "w") as ci_yml_file:
192+
ci_yml_file.write(
193+
Environment(
194+
loader=FileSystemLoader(
195+
Path(__file__).parent.joinpath("templates")
196+
)
197+
)
198+
.get_template("ci.yml.j2")
199+
.render()
200+
)
201+
ci_yml_file.write("\n")
202+
203+
200204
if __name__ == "__main__":
201205
tox_ini_path = Path(__file__).parent.parent.parent.joinpath("tox.ini")
202206
output_dir = Path(__file__).parent
@@ -205,3 +209,4 @@ def generate_misc_workflow(
205209
)
206210
generate_lint_workflow(tox_ini_path, output_dir)
207211
generate_misc_workflow(tox_ini_path, output_dir)
212+
generate_ci_workflow(output_dir)

.github/workflows/lint_0.yml renamed to .github/workflows/lint.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,14 @@
11
# Do not edit this file.
22
# This file is generated automatically by executing tox -e generate-workflows
33

4-
name: Lint 0
4+
name: Lint
55

66
on:
7-
push:
8-
branches:
9-
- 'main'
10-
pull_request:
7+
workflow_call:
118

129
permissions:
1310
contents: read
1411

15-
concurrency:
16-
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
17-
cancel-in-progress: true
18-
1912
env:
2013
CORE_REPO_SHA: main
2114
# Set the SHA to the branch name if the PR has a label 'prepare-release' or 'backport' otherwise, set it to 'main'

.github/workflows/misc_0.yml renamed to .github/workflows/misc.yml

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,14 @@
11
# Do not edit this file.
22
# This file is generated automatically by executing tox -e generate-workflows
33

4-
name: Misc 0
4+
name: Misc
55

66
on:
7-
push:
8-
branches:
9-
- 'main'
10-
pull_request:
7+
workflow_call:
118

129
permissions:
1310
contents: read
1411

15-
concurrency:
16-
group: ${{ github.workflow }}-${{ github.head_ref || github.run_id }}
17-
cancel-in-progress: true
18-
1912
env:
2013
CORE_REPO_SHA: main
2114
# Set the SHA to the branch name if the PR has a label 'prepare-release' or 'backport' otherwise, set it to 'main'

‎.github/workflows/templates/ci.yml.j2‎

Lines changed: 48 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,48 @@
1+
# Do not edit this file.
2+
# This file is generated automatically by executing tox -e generate-workflows
3+
4+
name: CI
5+
6+
on:
7+
push:
8+
branches:
9+
- 'main'
10+
pull_request:
11+
12+
permissions:
13+
contents: read
14+
15+
concurrency:
16+
group: ${% raw %}{{ github.workflow }}-${{ github.head_ref || github.run_id }}{% endraw %}
17+
cancel-in-progress: true
18+
19+
jobs:
20+
misc:
21+
uses: ./.github/workflows/misc.yml
22+
lint:
23+
uses: ./.github/workflows/lint.yml
24+
tests:
25+
uses: ./.github/workflows/test.yml
26+
contrib:
27+
uses: open-telemetry/opentelemetry-python-contrib/.github/workflows/core_contrib_test.yml@main
28+
with:
29+
CORE_REPO_SHA: ${% raw %}{{ github.sha }}{% endraw %}
30+
CONTRIB_REPO_SHA: {% raw %}${{ github.event_name == 'pull_request' && (
31+
contains(github.event.pull_request.labels.*.name, 'prepare-release') && github.event.pull_request.head.ref ||
32+
contains(github.event.pull_request.labels.*.name, 'backport') && github.event.pull_request.base.ref ||
33+
'main'
34+
) || 'main' }}{% endraw %}
35+
36+
check:
37+
if: always()
38+
needs:
39+
- misc
40+
- lint
41+
- tests
42+
- contrib
43+
runs-on: ubuntu-latest
44+
steps:
45+
- name: Decide whether the needed jobs succeeded or failed
46+
uses: re-actors/alls-green@release/v1
47+
with:
48+
jobs: ${% raw %}{{ toJSON(needs) }}{% endraw %}

‎.github/workflows/templates/lint.yml.j2‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,14 @@
11
# Do not edit this file.
22
# This file is generated automatically by executing tox -e generate-workflows
33

4-
name: Lint {{ file_number }}
4+
name: Lint
55

66
on:
7-
push:
8-
branches:
9-
- 'main'
10-
pull_request:
7+
workflow_call:
118

129
permissions:
1310
contents: read
1411

15-
concurrency:
16-
group: ${% raw %}{{ github.workflow }}-${{ github.head_ref || github.run_id }}{% endraw %}
17-
cancel-in-progress: true
18-
1912
env:
2013
CORE_REPO_SHA: main
2114
# Set the SHA to the branch name if the PR has a label 'prepare-release' or 'backport' otherwise, set it to 'main'

‎.github/workflows/templates/misc.yml.j2‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,14 @@
11
# Do not edit this file.
22
# This file is generated automatically by executing tox -e generate-workflows
33

4-
name: Misc {{ file_number }}
4+
name: Misc
55

66
on:
7-
push:
8-
branches:
9-
- 'main'
10-
pull_request:
7+
workflow_call:
118

129
permissions:
1310
contents: read
1411

15-
concurrency:
16-
group: ${% raw %}{{ github.workflow }}-${{ github.head_ref || github.run_id }}{% endraw %}
17-
cancel-in-progress: true
18-
1912
env:
2013
CORE_REPO_SHA: main
2114
# Set the SHA to the branch name if the PR has a label 'prepare-release' or 'backport' otherwise, set it to 'main'

‎.github/workflows/templates/test.yml.j2‎

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,21 +1,14 @@
11
# Do not edit this file.
22
# This file is generated automatically by executing tox -e generate-workflows
33

4-
name: Test {{ file_number }}
4+
name: Test
55

66
on:
7-
push:
8-
branches:
9-
- 'main'
10-
pull_request:
7+
workflow_call:
118

129
permissions:
1310
contents: read
1411

15-
concurrency:
16-
group: ${% raw %}{{ github.workflow }}-${{ github.head_ref || github.run_id }}{% endraw %}
17-
cancel-in-progress: true
18-
1912
env:
2013
CORE_REPO_SHA: main
2114
# Set the SHA to the branch name if the PR has a label 'prepare-release' or 'backport' otherwise, set it to 'main'

0 commit comments

Comments
 (0)