Skip to content

Commit 3ba556f

Browse files
Manvi2402xrmxMikeGoldsmith
authored
Fix shim docstring example (#5077)
* Fix incorrect code example in create_tracer() docstring * Update changelog * Apply suggestion from @xrmx --------- Co-authored-by: Riccardo Magliocchetti <riccardo.magliocchetti@gmail.com> Co-authored-by: Mike Goldsmith <goldsmith.mike@gmail.com>
1 parent b6ffddd commit 3ba556f

2 files changed

Lines changed: 5 additions & 3 deletions

File tree

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,8 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
1212

1313
## Unreleased
1414

15+
- Fix incorrect code example in `create_tracer()` docstring
16+
([#5072](https://github.com/open-telemetry/opentelemetry-python/issues/5072))
1517
- `opentelemetry-sdk`: add `load_entry_point` shared utility to declarative file configuration for loading plugins via entry points; refactor propagator loading to use it
1618
([#5093](https://github.com/open-telemetry/opentelemetry-python/pull/5093))
1719
- `opentelemetry-sdk`: fix YAML structure injection via environment variable substitution in declarative file configuration; values containing newlines are now emitted as quoted YAML scalars per spec requirement

shim/opentelemetry-opentracing-shim/src/opentelemetry/shim/opentracing_shim/__init__.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -35,11 +35,11 @@
3535
# Define which OpenTelemetry Tracer provider implementation to use.
3636
trace.set_tracer_provider(TracerProvider())
3737
38-
# Create an OpenTelemetry Tracer.
39-
otel_tracer = trace.get_tracer(__name__)
38+
# Get the OpenTelemetry TracerProvider.
39+
tracer_provider = trace.get_tracer_provider()
4040
4141
# Create an OpenTracing shim.
42-
shim = create_tracer(otel_tracer)
42+
shim = create_tracer(tracer_provider)
4343
4444
with shim.start_active_span("ProcessHTTPRequest"):
4545
print("Processing HTTP request")

0 commit comments

Comments
 (0)