5.5 support: Backport Ptype_external (#2775)

The original string syntax (eg. `{del| .. |del}`) is not respected
because this is probably unecessary.

Author: Julow

CHANGES.md

@@ -8,7 +8,7 @@ profile. This started with version 0.26.0.
 
 ### Highlight
 
-- Support OCaml 5.5 syntax (#2772, #2774, @Julow)
+- Support OCaml 5.5 syntax (#2772, #2774, #2775, @Julow)
 
 - \* Update Odoc's parser to 3.0 (#2757, @Julow)
   The indentation of code-blocks containing OCaml code is reduced by 2 to avoid

lib/Ast.ml

@@ -336,7 +336,7 @@ end
 module Tyd = struct
   let is_simple x =
     match x.ptype_kind with
-    | Ptype_abstract | Ptype_open -> true
+    | Ptype_abstract | Ptype_open | Ptype_external _ -> true
     | Ptype_variant _ | Ptype_record _ -> false
 end
 

lib/Exposed.ml

@@ -63,7 +63,8 @@ module Right = struct
     | {ptype_cstrs= _ :: _ as cstrs; _} ->
         (* type a = ... constraint left = < ... > *)
         list ~elt:(fun (_left, right, _loc) -> core_type right) cstrs
-    | {ptype_kind= Ptype_open | Ptype_record _; _} -> false
+    | {ptype_kind= Ptype_open | Ptype_record _ | Ptype_external _; _} ->
+        false
     | {ptype_kind= Ptype_abstract; ptype_manifest= None; _} -> false
     | {ptype_kind= Ptype_abstract; ptype_manifest= Some manifest; _} ->
         (* type a = < ... > *)

lib/Fmt_ast.ml

@@ -3602,6 +3602,11 @@ and fmt_type_declaration c ?(kw = "") ?(nonrec_kw = "") ?name ?(eq = "=")
         $ p.box_record (list_fl lbl_decls fmt_decl)
         $ p.break_after $ p.docked_after
     | Ptype_open -> box_manifest (fmt_manifest m $ str " ..")
+    | Ptype_external n ->
+        box_manifest
+          ( fmt_manifest m $ space_break $ str "external \""
+          $ str (String.escaped n)
+          $ str "\"" )
   in
   let fmt_cstr (t1, t2, loc) =
     Cmts.fmt c loc

test/passing/refs.ahrefs/types-compact-space_around-docked.ml.ref

@@ -235,3 +235,16 @@ type t =
       exp2 : Exp.t;
       loc : Location.t;
     }  (** *exp1 <- exp2 with exp2:typ *)
+
+type t = external "t"
+type u = external "u"
+
+module M : sig
+  type t = external "foo"
+end = struct
+  type t = external "foo"
+end
+
+type t = external ""
+type t = external "\003"
+type t = external "\\\\\\"

test/passing/refs.ahrefs/types-compact-space_around.ml.ref

@@ -235,3 +235,16 @@ type t =
       exp2 : Exp.t;
       loc : Location.t;
     }  (** *exp1 <- exp2 with exp2:typ *)
+
+type t = external "t"
+type u = external "u"
+
+module M : sig
+  type t = external "foo"
+end = struct
+  type t = external "foo"
+end
+
+type t = external ""
+type t = external "\003"
+type t = external "\\\\\\"

test/passing/refs.ahrefs/types-compact.ml.ref

@@ -235,3 +235,16 @@ type t =
       exp2 : Exp.t;
       loc : Location.t;
     }  (** *exp1 <- exp2 with exp2:typ *)
+
+type t = external "t"
+type u = external "u"
+
+module M : sig
+  type t = external "foo"
+end = struct
+  type t = external "foo"
+end
+
+type t = external ""
+type t = external "\003"
+type t = external "\\\\\\"

test/passing/refs.ahrefs/types-indent.ml.ref

@@ -275,3 +275,16 @@ type t =
       exp2 : Exp.t;
       loc : Location.t;
     }  (** *exp1 <- exp2 with exp2:typ *)
+
+type t = external "t"
+type u = external "u"
+
+module M : sig
+  type t = external "foo"
+end = struct
+  type t = external "foo"
+end
+
+type t = external ""
+type t = external "\003"
+type t = external "\\\\\\"

test/passing/refs.ahrefs/types-sparse-space_around.ml.ref

@@ -275,3 +275,16 @@ type t =
       exp2 : Exp.t;
       loc : Location.t;
     }  (** *exp1 <- exp2 with exp2:typ *)
+
+type t = external "t"
+type u = external "u"
+
+module M : sig
+  type t = external "foo"
+end = struct
+  type t = external "foo"
+end
+
+type t = external ""
+type t = external "\003"
+type t = external "\\\\\\"

test/passing/refs.ahrefs/types-sparse.ml.ref

@@ -275,3 +275,16 @@ type t =
       exp2 : Exp.t;
       loc : Location.t;
     }  (** *exp1 <- exp2 with exp2:typ *)
+
+type t = external "t"
+type u = external "u"
+
+module M : sig
+  type t = external "foo"
+end = struct
+  type t = external "foo"
+end
+
+type t = external ""
+type t = external "\003"
+type t = external "\\\\\\"