refactor: migrate to Leaflet V2

[Gugustinette]

Once @Maxel01 vue-leaflet is ready, we should migrate and go all-in on Leaflet V2.

This includes :

• Making sure existing components still work
  • If there are breaking changes, elegantly document them
• Documenting new components or composables
• Making sure Leaflet Plugins are still usable in some way ?

[Maxel01]

Current update:
I am planning on releasing the beta version in the next 7 days, once I'm done with writing more tests. The goal is to reach a coverage of 100%. Of course, this doesn't mean that every piece of code is tested for every case. This should bring some confidence to the wrapper. In my opinion, it should be better than before.
Please reach out if there are any issues.

The biggest problem should be using the plugins. Most of them are outdated and very unlikely that they will be migrated to v2, unless the community helps to migrate them (see here).

I should have marked every breaking change in the commit history. It shouldn't change that much, but I will create a detailed changelog once I am releasing the stable release.

[Maxel01]

Hey,
The wrapper should be ready now (still in beta until leaflet v2 is officially out).
It's worth a try to provide the leaflet v2 wrapper.

These are the breaking changes so far:

• remove WINDOW_OR_GLOBAL from utils
• core: remove type Data from utils
• core: remove useGlobalLeafletcore: crs value now needs to be a value of CRS class

There are 2 new components:

• LSVGOverlay
• LVideoOverlay

The documentation is auto-generated.

I started a repo to provide vue-leaflet-plugins. I found a way to use all the v1 plugins with leaflet v2. See Leaflet-V1-Polyfill. I already tested it with the MarkerCluster plugin.

What do you think about switching now to leaflet v2? Do you need additional information?

[Gugustinette]

Yes, it might be time to work on the Leaflet V2 migration (which should fixe #75 btw) !

I'll take care of wiring everything correctly in Nuxt Leaflet. 👍

[Maxel01]

Great.

It works in my nuxt playground at least :D
This also resolves #124
The composables are obsolete then. I just added the Leaflet.heat as it is supported by this wrapper. That should be published soon.

[productdevbook]

What is our status on this matter? When will work begin on v2?

[Gugustinette]

I started some work here : https://github.com/nuxt-modules/leaflet/tree/v2.0.0

@Maxel01 Your wrapper works very well so far, you did very impressive work on this ! 😆

[Maxel01]

Thank you a lot 😄
It looks also very well in your module.
It is a good implementation with all the plugin flags.
Let me know if you need any support regarding the documentation (breaking changes, etc.)

[Maxel01]

Hi,
I just checked the last commit for v2. I found another mismatching value im the module.ts for LRotatedMarker.
I wanted to know if there is still something missing that needs to be updated. I hope leaflet v2 is ready soon (planned release date is November but I don't know if they will postpone it). Anyways, I would be happy if the nuxt wrapper is ready as soon as leaflet v2 is out. So let me know what needs to be done.

[Gugustinette]

@Maxel01

I'm just waiting for a stable v2 release, as they could still introduce breaking changes (which was the case between v2.0.0-alpha and v2.0.0-alpha.1).

It's just to prevent unnecessary work, but I'll make the migration as fast as possible once Leaflet v2 is released, there isn't much to do on Nuxt Leaflet side anyway. 👍

[productdevbook]

Can you publish this as a beta to test the project?

[Gugustinette]

Pinging Leaflet V2 discussions here : Leaflet/Leaflet#9869

I don't intend to publish a beta, as Nuxt Leaflet does not bring much innovation. It's just a small helper for DX.
If you want to try Leaflet V2 early, use vue-leaflet directly. 👍