lib: revert compression changes and drop semver-major changes

Signed-off-by: Ali Hassan <ali-hassan27@outlook.com>

Author: thisalihassan

lib/internal/blob.js

@@ -45,7 +45,6 @@ const {
 const {
   isAnyArrayBuffer,
   isArrayBufferView,
-  isSharedArrayBuffer,
 } = require('internal/util/types');
 
 const {
@@ -110,21 +109,6 @@ function getSource(source, endings) {
   if (isBlob(source))
     return [source.size, source[kHandle]];
 
-  if (isSharedArrayBuffer(source)) {
-    throw new ERR_INVALID_ARG_TYPE(
-      'source',
-      ['ArrayBuffer', 'TypedArray', 'DataView', 'Blob', 'string'],
-      source,
-    );
-  }
-  if (isArrayBufferView(source) && isSharedArrayBuffer(source.buffer)) {
-    throw new ERR_INVALID_ARG_VALUE(
-      'source',
-      source,
-      'must not be backed by a SharedArrayBuffer',
-    );
-  }
-
   if (isAnyArrayBuffer(source)) {
     source = new Uint8Array(source);
   } else if (!isArrayBufferView(source)) {

lib/internal/webstreams/compression.js

@@ -26,7 +26,6 @@ const {
 const {
   codes: {
     ERR_INVALID_ARG_TYPE,
-    ERR_INVALID_ARG_VALUE,
   },
 } = require('internal/errors');
 
@@ -41,20 +40,13 @@ function lazyZlib() {
 // Per the Compression Streams spec, chunks must be BufferSource
 // (ArrayBuffer or ArrayBufferView not backed by SharedArrayBuffer).
 function validateBufferSourceChunk(chunk) {
-  if (isSharedArrayBuffer(chunk)) {
+  if (isArrayBufferView(chunk) && isSharedArrayBuffer(chunk.buffer)) {
     throw new ERR_INVALID_ARG_TYPE(
       'chunk',
       ['ArrayBuffer', 'Buffer', 'TypedArray', 'DataView'],
       chunk,
     );
   }
-  if (isArrayBufferView(chunk) && isSharedArrayBuffer(chunk.buffer)) {
-    throw new ERR_INVALID_ARG_VALUE(
-      'chunk',
-      chunk,
-      'must not be backed by a SharedArrayBuffer',
-    );
-  }
 }
 
 const formatConverter = createEnumConverter('CompressionFormat', [

test/parallel/test-webapi-sharedarraybuffer-rejection.js

@@ -3,46 +3,12 @@
 const common = require('../common');
 const assert = require('assert');
 const test = require('node:test');
-const { Blob } = require('buffer');
-const { ReadableStream, CompressionStream, DecompressionStream } = require('stream/web');
+const { ReadableStream } = require('stream/web');
 
 const sab = new SharedArrayBuffer(8);
 const sabView = new Uint8Array(sab);
 const sabDataView = new DataView(sab);
 
-// -- Blob constructor --
-
-test('Blob rejects raw SharedArrayBuffer', () => {
-  assert.throws(
-    () => new Blob([sab]),
-    { code: 'ERR_INVALID_ARG_TYPE' },
-  );
-});
-
-test('Blob rejects Uint8Array backed by SharedArrayBuffer', () => {
-  assert.throws(
-    () => new Blob([sabView]),
-    { code: 'ERR_INVALID_ARG_VALUE' },
-  );
-});
-
-test('Blob rejects DataView backed by SharedArrayBuffer', () => {
-  assert.throws(
-    () => new Blob([sabDataView]),
-    { code: 'ERR_INVALID_ARG_VALUE' },
-  );
-});
-
-test('Blob still accepts regular ArrayBuffer', () => {
-  const blob = new Blob([new ArrayBuffer(4)]);
-  assert.strictEqual(blob.size, 4);
-});
-
-test('Blob still accepts regular Uint8Array', () => {
-  const blob = new Blob([new Uint8Array(4)]);
-  assert.strictEqual(blob.size, 4);
-});
-
 // -- ReadableStreamBYOBReader.read() --
 
 test('ReadableStreamBYOBReader.read() rejects SAB-backed Uint8Array', async () => {
@@ -132,34 +98,6 @@ test('ReadableByteStreamController.enqueue() rejects SAB-backed DataView', async
   reader.releaseLock();
 });
 
-// -- Compression/Decompression streams reject raw SharedArrayBuffer --
-
-for (const format of ['deflate', 'gzip', 'deflate-raw', 'brotli']) {
-  test(`CompressionStream rejects raw SharedArrayBuffer for ${format}`, async () => {
-    const cs = new CompressionStream(format);
-    const writer = cs.writable.getWriter();
-    const reader = cs.readable.getReader();
-
-    const writePromise = writer.write(sab);
-    const readPromise = reader.read();
-
-    await assert.rejects(writePromise, { code: 'ERR_INVALID_ARG_TYPE' });
-    await assert.rejects(readPromise, { code: 'ERR_INVALID_ARG_TYPE' });
-  });
-
-  test(`DecompressionStream rejects raw SharedArrayBuffer for ${format}`, async () => {
-    const ds = new DecompressionStream(format);
-    const writer = ds.writable.getWriter();
-    const reader = ds.readable.getReader();
-
-    const writePromise = writer.write(sab);
-    const readPromise = reader.read();
-
-    await assert.rejects(writePromise, { code: 'ERR_INVALID_ARG_TYPE' });
-    await assert.rejects(readPromise, { code: 'ERR_INVALID_ARG_TYPE' });
-  });
-}
-
 // -- SharedWebIDL converters --
 
 const { converters } = require('internal/webidl');

test/parallel/test-webstreams-compression-bad-chunks.js

@@ -22,7 +22,7 @@ const badChunks = [
   {
     name: 'Uint8Array backed by SharedArrayBuffer',
     value: new Uint8Array(new SharedArrayBuffer(1)),
-    code: 'ERR_INVALID_ARG_VALUE',
+    code: 'ERR_INVALID_ARG_TYPE',
   },
 ];