Skip to content

Commit a7f487f

Browse files
authored
src: add missing <cstdlib> for abort() declaration
builtin_info.cc calls `abort()` but didn't call `<cstdlib>` to pick up its declaration. This has been working because `abort()` got picked up by a transitive declaration from another header, but it broke in Electron when we rolled our LLVM libc++ snapshot from commit 8e870711923 to 9aaa9a2ee87. Signed-off-by: Charles Kerr <charles@charleskerr.com> PR-URL: #63001 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Richard Lau <richard.lau@ibm.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
1 parent a962e72 commit a7f487f

1 file changed

Lines changed: 2 additions & 1 deletion

File tree

src/builtin_info.cc

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,5 @@
11
#include "builtin_info.h"
2+
#include <cstdlib>
23

34
namespace node {
45
namespace builtins {
@@ -41,7 +42,7 @@ std::string GetBuiltinSourceTypeName(BuiltinSourceType type) {
4142
case BuiltinSourceType::kSourceTextModule:
4243
return "kSourceTextModule";
4344
}
44-
abort();
45+
std::abort();
4546
}
4647

4748
} // namespace builtins

0 commit comments

Comments
 (0)