Skip to content

Commit 37e2c4c

Browse files
thibaudmichaudguybedford
authored andcommitted
deps: V8: backport 85b390089e51
Original commit message: [wasm][eh] Fix getArg() when exception has an S128 We cannot read an S128 exception value from JS, but we can read a value at a higher index in the exception. So accept S128 values when we compute the encoded index. R=mliedtke@chromium.org Fixed: 403675482 Change-Id: I7cc0238310863b6d579fcbe0a216ddce6f760c8b Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/6367014 Reviewed-by: Matthias Liedtke <mliedtke@chromium.org> Commit-Queue: Thibaud Michaud <thibaudm@chromium.org> Cr-Commit-Position: refs/heads/main@{#99305} Refs: v8/v8@85b390089e51
1 parent ff4b2c7 commit 37e2c4c

2 files changed

Lines changed: 4 additions & 2 deletions

File tree

common.gypi

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,7 +38,7 @@
3838

3939
# Reset this number to 0 on major V8 upgrades.
4040
# Increment by one for each non-official patch applied to deps/v8.
41-
'v8_embedder_string': '-node.55',
41+
'v8_embedder_string': '-node.56',
4242

4343
##### V8 defaults for Node.js #####
4444

deps/v8/src/wasm/wasm-js.cc

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2754,12 +2754,14 @@ void WebAssemblyExceptionGetArgImpl(
27542754
case i::wasm::kRefNull:
27552755
decode_index++;
27562756
break;
2757+
case i::wasm::kS128:
2758+
decode_index += 8;
2759+
break;
27572760
case i::wasm::kRtt:
27582761
case i::wasm::kI8:
27592762
case i::wasm::kI16:
27602763
case i::wasm::kVoid:
27612764
case i::wasm::kBottom:
2762-
case i::wasm::kS128:
27632765
UNREACHABLE();
27642766
}
27652767
}

0 commit comments

Comments
 (0)