fixup! src,lib: initial ffi implementation

Author: bengl

src/node_binding.cc

@@ -1,4 +1,5 @@
 #include "node_binding.h"
+#include <dlfcn.h>
 #include <atomic>
 #include "env-inl.h"
 #include "node_builtins.h"
@@ -328,10 +329,15 @@ static struct global_handle_map_t {
 } global_handle_map;
 
 DLib::DLib(const char* filename, int flags)
-    : filename_(filename), flags_(flags), handle_(nullptr) {}
+    : filename_(filename), flags_(flags), handle_(nullptr), is_self_(false) {}
+DLib::DLib(int flags) : flags_(flags), handle_(nullptr), is_self_(true) {}
 
 #ifdef __POSIX__
 bool DLib::Open() {
+  if (is_self_) {
+    handle_ = RTLD_DEFAULT;
+    return true;
+  }
   handle_ = dlopen(filename_.c_str(), flags_);
   if (handle_ != nullptr) return true;
   errmsg_ = dlerror();
@@ -363,6 +369,7 @@ void* DLib::GetSymbolAddress(const char* name) {
 }
 #else   // !__POSIX__
 bool DLib::Open() {
+  if (is_self_) return true;
   int ret = uv_dlopen(filename_.c_str(), &lib_);
   if (ret == 0) {
     handle_ = static_cast<void*>(lib_.handle);

src/node_binding.h

@@ -77,6 +77,7 @@ class DLib {
 #endif
 
   DLib(const char* filename, int flags);
+  DLib(int flags);
 
   bool Open();
   void Close();
@@ -92,6 +93,7 @@ class DLib {
   uv_lib_t lib_;
 #endif
   bool has_entry_in_global_handle_map_ = false;
+  bool is_self_;
 
   DLib(const DLib&) = delete;
   DLib& operator=(const DLib&) = delete;

src/node_ffi.cc

@@ -42,13 +42,15 @@ void GetLibrary(const v8::FunctionCallbackInfo<Value>& args) {
   if (libraries[fname] != nullptr) {
     lib = libraries[fname];
   } else {
-    lib = new binding::DLib(fname.c_str(), binding::DLib::kDefaultFlags);
+    if (isNull) {
+      lib = new binding::DLib(binding::DLib::kDefaultFlags);
+    } else {
+      lib = new binding::DLib(fname.c_str(), binding::DLib::kDefaultFlags);
+    }
     libraries[fname] = lib;
-    if (!isNull) {
-      bool success = lib->Open();
-      if (!success) {
-        // TODO(bengl) what now?
-      }
+    bool success = lib->Open();
+    if (!success) {
+      // TODO(bengl) what now?
     }
   }
   ReturnBigInt(env->isolate(), lib);

test/parallel/test-ffi-self.js

@@ -0,0 +1,7 @@
+'use strict';
+require('../common');
+const assert = require('assert');
+const ffi = require('node:ffi');
+
+const getpid = ffi.getNativeFunction(null, 'uv_os_getpid', 'int', []);
+assert.strictEqual(process.pid, getpid());