fix(hybrid): allow sending redirect_uri param to avoid redirect URI mismatch errors#118
Open
wJoenn wants to merge 2 commits into
Open
fix(hybrid): allow sending redirect_uri param to avoid redirect URI mismatch errors#118wJoenn wants to merge 2 commits into
wJoenn wants to merge 2 commits into
Conversation
This was referenced Feb 13, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #115
Summary
When using
omniauth-applewith a API only Rails application it's common for the initial request to be made from the client side application instead of from Rails.The client side application then receives a authorization code which it POST to
/auth/apple/callbackand the code is verified from the API before finally signing the user in.When doing so the
redirect_uriused in the callback process needs to be the same as theredirect_uriused in the request process so we need to be able to share thatredirect_urifrom the client side app to the API.This is also the case with other
omniauth-<provider>gem.This PR allows sending a
redirect_uriparam to the/auth/apple/callbackendpoint from a client side application and ensures that param will be used when present to avoid redirect uri mismatch errors.Until this PR is merged this issue can be monkey patched by initializing a custom class that will override this gem