Merge pull request #59121 from nextcloud/dependabot/npm_and_yarn/eslint-10.1.0

chore(deps-dev): Bump eslint from 9.39.2 to 10.1.0

Author: github-actions[bot]

.github/dependabot.yml

@@ -53,7 +53,14 @@ updates:
     - "feature: dependencies"
   # Disable automatic rebasing because without a build CI will likely fail anyway
   rebase-strategy: "disabled"
+  cooldown:
+    default-days: 4
+    semver-major-days: 8
   groups:
+    eslint:
+      patterns:
+        - "eslint*"
+        - "@nextcloud/eslint-config"
     vite:
       patterns:
         - "vite"
@@ -101,6 +108,9 @@ updates:
     day: saturday
     time: "03:30"
     timezone: Europe/Paris
+  cooldown:
+    default-days: 4
+    semver-major-days: 8
   open-pull-requests-limit: 20
   labels:
     - "3. to review"
@@ -155,6 +165,9 @@ updates:
     day: saturday
     time: "04:30"
     timezone: Europe/Paris
+  cooldown:
+    default-days: 4
+    semver-major-days: 8
   open-pull-requests-limit: 20
   labels:
     - "3. to review"

apps/dav/src/components/AbsenceForm.vue

@@ -149,7 +149,7 @@ export default {
 				ShareType.User,
 			]
 
-			let request = null
+			let request
 			try {
 				request = await axios.get(generateOcsUrl('apps/files_sharing/api/v1/sharees'), {
 					params: {

apps/files/src/components/FilesListVirtual.vue

@@ -428,8 +428,7 @@ export default defineComponent({
 			}
 
 			if (event.key !== 'ArrowUp' && event.key !== 'ArrowDown'
-				&& (!this.userConfig.grid_view || (event.key !== 'ArrowLeft' && event.key !== 'ArrowRight'))
-			) {
+				&& (!this.userConfig.grid_view || (event.key !== 'ArrowLeft' && event.key !== 'ArrowRight'))) {
 				// not an arrow key we handle
 				return
 			}

apps/files/src/components/FilesNavigationListItem.vue

@@ -141,7 +141,7 @@ export default {
 		allow-collapse
 		:loading="isLoading"
 		:data-cy-files-navigation-item="view.id"
-		:exact="hasChildViews /* eslint-disable-line @nextcloud/vue/no-deprecated-props */"
+		:exact="hasChildViews"
 		:name="view.name"
 		:open="isExpanded"
 		:pinned="view.sticky"

apps/files/src/composables/usePreviewImage.ts

@@ -38,8 +38,7 @@ export function usePreviewImage(
 		const fallback = toValue(options).fallback ?? true
 		if (source.attributes['has-preview'] !== true
 			&& source.mime !== undefined
-			&& source.mime !== 'application/octet-stream'
-		) {
+			&& source.mime !== 'application/octet-stream') {
 			if (!fallback) {
 				return
 			}

apps/files/src/store/renaming.ts

@@ -66,8 +66,7 @@ export const useRenamingStore = defineStore('renaming', () => {
 				// Check for extension change for files
 				if (node.type === FileType.File
 					&& oldExtension !== newExtension
-					&& !(await showFileExtensionDialog(oldExtension, newExtension))
-				) {
+					&& !(await showFileExtensionDialog(oldExtension, newExtension))) {
 					// user selected to use the old extension
 					newName = basename(newName, newExtension) + oldExtension
 					if (oldName === newName) {
@@ -78,8 +77,7 @@ export const useRenamingStore = defineStore('renaming', () => {
 				if (!userConfig.userConfig.show_hidden
 					&& newName.startsWith('.')
 					&& !oldName.startsWith('.')
-					&& !(await showHiddenFileDialog(newName))
-				) {
+					&& !(await showHiddenFileDialog(newName))) {
 					return false
 				}
 			}
@@ -126,7 +124,7 @@ export const useRenamingStore = defineStore('renaming', () => {
 			if (isAxiosError(error)) {
 				// TODO: 409 means current folder does not exist, redirect ?
 				if (error?.response?.status === 404) {
-					throw new Error(t('files', 'Could not rename "{oldName}", it does not exist any more', { oldName }))
+					throw new Error(t('files', 'Could not rename "{oldName}", it does not exist any more', { oldName }), { cause: error })
 				} else if (error?.response?.status === 412) {
 					throw new Error(t(
 						'files',
@@ -135,11 +133,11 @@ export const useRenamingStore = defineStore('renaming', () => {
 							newName,
 							dir: basename(renamingNode.value!.dirname),
 						},
-					))
+					), { cause: error })
 				}
 			}
 			// Unknown error
-			throw new Error(t('files', 'Could not rename "{oldName}"', { oldName }))
+			throw new Error(t('files', 'Could not rename "{oldName}"', { oldName }), { cause: error })
 		} finally {
 			Vue.set(node, 'status', undefined)
 			isRenaming.value = false

apps/files/src/utils/permissions.ts

@@ -21,8 +21,7 @@ export function isDownloadable(node: INode): boolean {
 
 	// check hide-download property of shares
 	if (node.attributes['hide-download'] === true
-		|| node.attributes['hide-download'] === 'true'
-	) {
+		|| node.attributes['hide-download'] === 'true') {
 		return false
 	}
 

apps/files_sharing/src/components/SharingInput.vue

@@ -231,7 +231,7 @@ export default {
 				shareType.push(...remoteTypes)
 			}
 
-			let request = null
+			let request
 			try {
 				request = await axios.get(generateOcsUrl('apps/files_sharing/api/v1/sharees'), {
 					params: {
@@ -321,7 +321,7 @@ export default {
 		async getRecommendations() {
 			this.loading = true
 
-			let request = null
+			let request
 			try {
 				request = await axios.get(generateOcsUrl('apps/files_sharing/api/v1/sharees_recommended'), {
 					params: {

apps/files_sharing/src/mixins/ShareDetails.js

@@ -11,7 +11,7 @@ import logger from '../services/logger.ts'
 export default {
 	methods: {
 		async openSharingDetails(shareRequestObject) {
-			let share = {}
+			let share
 			// handle externalResults from OCA.Sharing.ShareSearch
 			// TODO : Better name/interface for handler required
 			// For example `externalAppCreateShareHook` with proper documentation

apps/files_versions/src/utils/versions.ts

@@ -98,11 +98,11 @@ export async function restoreVersion(version: Version) {
  */
 function formatVersion(version: Required<FileStat>, node: INode): Version {
 	const mtime = Date.parse(version.lastmod)
-	let previewUrl = ''
 
+	let previewUrl: string
 	if (mtime === node.mtime?.getTime()) { // Version is the current one
 		previewUrl = generateUrl('/core/preview?fileId={fileId}&c={fileEtag}&x=250&y=250&forceIcon=0&a=0&forceIcon=1&mimeFallback=1', {
-			fileId: node.fileid,
+			fileId: node.id,
 			fileEtag: node.attributes.etag,
 		})
 	} else {
@@ -113,7 +113,7 @@ function formatVersion(version: Required<FileStat>, node: INode): Version {
 	}
 
 	return {
-		fileId: node.fileid!.toString(),
+		fileId: node.id!,
 		// If version-label is defined make sure it is a string (prevent issue if the label is a number an PHP returns a number then)
 		label: version.props['version-label'] ? String(version.props['version-label']) : '',
 		author: version.props['version-author'] ? String(version.props['version-author']) : null,