fix(NcRichText): migrate from 'remark-stringify' library with 'mdast-util-to-string'

- 'remark-stringify' returns serialized markdown, escaping its syntax, e.g. underscores. NcReferenceList needs only text content

Signed-off-by: Maksim Sukharev <antreesy.web@gmail.com>

Author: Antreesy

src/components/NcRichText/NcRichText.vue

@@ -306,13 +306,13 @@ See [NcRichContenteditable](#/Components/NcRichContenteditable) documentation fo
 </docs>
 
 <script>
+import { toString } from 'mdast-util-to-string'
 import rehypeExternalLinks from 'rehype-external-links'
 import rehype2react from 'rehype-react'
 import breaks from 'remark-breaks'
 import remarkGfm from 'remark-gfm'
 import remarkParse from 'remark-parse'
 import remark2rehype from 'remark-rehype'
-import remarkStringify from 'remark-stringify'
 import remarkUnlinkProtocols from 'remark-unlink-protocols'
 import { unified } from 'unified'
 import { ref } from 'vue'
@@ -627,10 +627,12 @@ export default {
 				return text
 			}
 
-			return unified()
+			const processor = unified()
+			processor.compiler = (tree) => toString(tree)
+
+			return processor
 				.use(remarkParse)
 				.use(remarkStripCode)
-				.use(remarkStringify)
 				.processSync(text)
 				.value
 		},

tests/unit/components/NcRichText/NcRichText.spec.js

@@ -3,11 +3,20 @@
  * SPDX-License-Identifier: AGPL-3.0-or-later
  */
 
-import { describe, expect, it, test } from '@jest/globals'
+import { describe, expect, it, jest, test } from '@jest/globals'
+import axios from '@nextcloud/axios'
 import { mount } from '@vue/test-utils'
 import { nextTick } from 'vue'
+import NcReferenceList from '../../../../src/components/NcRichText/NcReferenceList.vue'
 import NcRichText from '../../../../src/components/NcRichText/NcRichText.vue'
 
+jest.mock('@nextcloud/axios', () => ({
+	__esModule: true,
+	default: {
+		get: jest.fn().mockResolvedValue({ data: { ocs: { data: { references: {} } } } }),
+	},
+}))
+
 describe('NcRichText', () => {
 	it('renders a message and responds correctly to props changes', async () => {
 		const wrapper = mount(NcRichText, {
@@ -224,4 +233,18 @@ describe('NcRichText', () => {
 		await nextTick()
 		expect(wrapper.find('code').classes()).toEqual(['hljs', 'language-js'])
 	})
+
+	it('strips URL links from text source if wrapped in inline/code blocks Markdown', () => {
+		const testUrl = 'https://example.com/a_b'
+		const wrapper = mount(NcRichText, {
+			propsData: {
+				text: 'Inline `https://example.com/inline_b`\n```\nStripped text https://example.com/fenced_b\n```\n\nPlain ' + testUrl,
+				useMarkdown: true,
+				referenceLimit: 1,
+			},
+		})
+
+		expect(wrapper.findComponent(NcReferenceList).props('text').trim()).toBe('Inline Plain https://example.com/a_b')
+		expect(axios.get).toHaveBeenCalledWith(expect.stringContaining(encodeURIComponent(testUrl)))
+	})
 })