Skip to content

test(NODE-7147): Revert field presence changes from server 8.2.0#4928

Merged
PavelSafronov merged 1 commit intomainfrom
NODE-7147
Apr 29, 2026
Merged

test(NODE-7147): Revert field presence changes from server 8.2.0#4928
PavelSafronov merged 1 commit intomainfrom
NODE-7147

Conversation

@tadjik1
Copy link
Copy Markdown
Member

@tadjik1 tadjik1 commented Apr 27, 2026

Description

Summary of Changes

Updated spec tests for change stream. All affected files pass tests, failures unrelated (even though they are also about change streams).

Double check the following

  • Lint is passing (npm run check:lint)
  • Self-review completed using the steps outlined here
  • PR title follows the correct format: type(NODE-xxxx)[!]: description
    • Example: feat(NODE-1234)!: rewriting everything in coffeescript
  • Changes are covered by tests
  • New TODOs have a related JIRA ticket

@tadjik1 tadjik1 marked this pull request as ready for review April 27, 2026 13:56
@tadjik1 tadjik1 requested a review from a team as a code owner April 27, 2026 13:56
Copilot AI review requested due to automatic review settings April 27, 2026 13:56
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the unified change stream spec tests to reflect that updateDescription.disambiguatedPaths should not be present unless showExpandedEvents is enabled, while explicitly excluding the server behavior regression in MongoDB 8.2.0.

Changes:

  • Add a unified spec test asserting disambiguatedPaths is absent when showExpandedEvents is false/unset, skipping server 8.2.0 via version gating.
  • Adjust runOnRequirements topologies in the YAML spec test file to match the updated coverage set.
  • Keep YAML and JSON variants of the unified spec test in sync.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
test/spec/change-streams/unified/change-streams-disambiguatedPaths.yml Adds version-gated test ensuring disambiguatedPaths absence without showExpandedEvents; adjusts topologies list.
test/spec/change-streams/unified/change-streams-disambiguatedPaths.json JSON equivalent of the added test and requirements to keep unified spec coverage aligned.

@PavelSafronov PavelSafronov self-assigned this Apr 29, 2026
@PavelSafronov PavelSafronov added the Primary Review In Review with primary reviewer, not yet ready for team's eyes label Apr 29, 2026
@PavelSafronov PavelSafronov added the Team Review Needs review from team label Apr 29, 2026
@PavelSafronov PavelSafronov merged commit d9d371b into main Apr 29, 2026
22 of 36 checks passed
@PavelSafronov PavelSafronov deleted the NODE-7147 branch April 29, 2026 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Primary Review In Review with primary reviewer, not yet ready for team's eyes Team Review Needs review from team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants