Skip to content

Bring @gmponos PR forward with master#668

Open
jameswilddev wants to merge 43 commits into
moneyphp:masterfrom
jameswilddev:expo-parser
Open

Bring @gmponos PR forward with master#668
jameswilddev wants to merge 43 commits into
moneyphp:masterfrom
jameswilddev:expo-parser

Conversation

@jameswilddev

Copy link
Copy Markdown

This is identical to #520 but caught up with master.

@jameswilddev

Copy link
Copy Markdown
Author

Right, got that to pass everything but the mutation tests. I don't really know how to fix those (a lot of what it flags isn't stuff I've changed).

@frederikbosch

Copy link
Copy Markdown
Member

Great work @jameswilddev and @gmponos (!). To what extend is the exponential parser also able to parse normal numbers?

@jameswilddev

Copy link
Copy Markdown
Author

I'll be honest I haven't looked at the base PR in depth; I've only checked out the branch, merged master and fixed CI failures.

In my case I'm maintaining a product which uses Money and found a bug where entering "1e1" would get past validation, but then cause a parser error and figured this could well be fix.

@frederikbosch

Copy link
Copy Markdown
Member

What is the use again of this Parser/Formatter? Maybe it is time to merge this in after 4 years..... sorry guys!

@gmponos

gmponos commented Dec 16, 2022

Copy link
Copy Markdown
Contributor

What is the use again of this Parser/Formatter? Maybe it is time to merge this in after 4 years..... sorry guys!

Hi, haven't fully understood the question.

  • We haven't submitted a formatter..
  • The use cases are on the tests.

Not sure if I miss something.. sorry

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants