Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/actions/run-test/action.yml
Original file line number Diff line number Diff line change
@@ -1,6 +1,9 @@
name: 'Run browser tests'
description: 'Run browser tests'
inputs:
setup-command:
description: 'Extra setup command to run before tests'
required: false
command:
description: 'Command to run tests'
required: true
Expand Down Expand Up @@ -56,6 +59,10 @@ runs:
shell: bash
- run: echo "PLAYWRIGHT_SETUP_COMPLETE=true" >> $GITHUB_ENV
shell: bash
- name: Run setup command
if: inputs.setup-command != ''
run: ${{ inputs.setup-command }}
shell: bash
- name: Run tests
if: inputs.shell == 'bash'
run: |
Expand Down
2 changes: 0 additions & 2 deletions .github/workflows/create_test_report.yml
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,6 @@ jobs:
with:
node-version: 20
- run: npm ci
env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1
- run: npm run build

- name: Download blob report artifact
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/infra.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ on:
- main
- release-*

env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
doc-and-lint:
name: "docs & lint"
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/publish_release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,6 @@ on:
release:
types: [published]

env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
publish-npm-and-driver:
name: "publish NPM and driver"
Expand Down
3 changes: 0 additions & 3 deletions .github/workflows/publish_release_docker.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ on:
release:
types: [published]

env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
publish-docker-release:
name: "publish to DockerHub"
Expand Down
3 changes: 1 addition & 2 deletions .github/workflows/roll_browser_into_playwright.yml
Original file line number Diff line number Diff line change
Expand Up @@ -5,15 +5,14 @@ on:
types: [roll_into_pw]

env:
ELECTRON_SKIP_BINARY_DOWNLOAD: 1
BROWSER: ${{ github.event.client_payload.browser }}
REVISION: ${{ github.event.client_payload.revision }}
BROWSER_VERSION: ${{ github.event.client_payload.browserVersion }}

permissions:
contents: write

concurrency:
concurrency:
group: 'roll-browser-into-playwright-${{ github.event.client_payload.browser }}-${{ github.event.client_payload.revision }}'

jobs:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/tests_components.yml
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,6 @@ on:

env:
FORCE_COLOR: 1
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
test_components:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/tests_extension.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,6 @@ concurrency:

env:
FORCE_COLOR: 1
ELECTRON_SKIP_BINARY_DOWNLOAD: 1
DEBUG: pw:mcp:error

jobs:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/tests_mcp.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ concurrency:
env:
# Force terminal colors. @see https://www.npmjs.com/package/colors
FORCE_COLOR: 1
ELECTRON_SKIP_BINARY_DOWNLOAD: 1
DEBUG: pw:mcp:error

jobs:
Expand Down
4 changes: 1 addition & 3 deletions .github/workflows/tests_others.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@ on:

env:
FORCE_COLOR: 1
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
test_clock_frozen_time_linux:
Expand Down Expand Up @@ -93,10 +92,9 @@ jobs:
- uses: ./.github/actions/run-test
with:
browsers-to-install: chromium
setup-command: npx install-electron --no
command: npm run etest
bot-name: "electron-${{ matrix.os }}"
flakiness-client-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_CLIENT_ID }}
flakiness-tenant-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_TENANT_ID }}
flakiness-subscription-id: ${{ secrets.AZURE_FLAKINESS_DASHBOARD_SUBSCRIPTION_ID }}
env:
ELECTRON_SKIP_BINARY_DOWNLOAD:
1 change: 0 additions & 1 deletion .github/workflows/tests_primary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,6 @@ concurrency:
env:
# Force terminal colors. @see https://www.npmjs.com/package/colors
FORCE_COLOR: 1
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
test_linux:
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/tests_secondary.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ on:
env:
# Force terminal colors. @see https://www.npmjs.com/package/colors
FORCE_COLOR: 1
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

permissions:
id-token: write # This is required for OIDC login (azure/login) to succeed
Expand Down
1 change: 0 additions & 1 deletion .github/workflows/tests_webview_simulator.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@ concurrency:

env:
FORCE_COLOR: 1
ELECTRON_SKIP_BINARY_DOWNLOAD: 1

jobs:
test_webview_simulator:
Expand Down
Loading
Loading