controller/network: add unit tests for LCOW network controller

15 tests covering teardown cleanup chains (partial NIC failure continues,
failed NICs stay tracked for retry from Invalid state), state machine
transitions (idempotent teardown, no-op on unconfigured, duplicate Setup
rejected), LCOW endpoint add/remove operations (host-before-guest ordering
via InOrder, BuildLCOWNetworkAdapter struct verification, guest-fail still
tracked for cleanup, host-fail not tracked), nil-capabilities disabling
guest ops, and State.String().

Mocks generated for vmNetworkManager, linuxGuestNetworkManager, and
capabilitiesProvider. GCS GuestDefinedCapabilities mock reused from
internal/gcs/mock/.

Signed-off-by: Shreyansh Sancheti <shsancheti@microsoft.com>

Author: Shreyansh Sancheti

internal/controller/network/export_test.go

@@ -0,0 +1,54 @@
+//go:build windows
+
+package network
+
+import (
+	"context"
+
+	"github.com/Microsoft/hcsshim/hcn"
+)
+
+// SetStateForTest sets the Manager's state. Test-only.
+func (m *Manager) SetStateForTest(s State) {
+	m.netState = s
+}
+
+// StateForTest returns the Manager's current state. Test-only.
+func (m *Manager) StateForTest() State {
+	return m.netState
+}
+
+// SetNamespaceIDForTest sets the namespace ID on the Manager. Test-only.
+func (m *Manager) SetNamespaceIDForTest(id string) {
+	m.namespaceID = id
+}
+
+// AddEndpointForTest adds a NIC→endpoint mapping to the internal tracking map. Test-only.
+func (m *Manager) AddEndpointForTest(nicID string, ep *hcn.HostComputeEndpoint) {
+	m.vmEndpoints[nicID] = ep
+}
+
+// EndpointsForTest returns the current vmEndpoints map. Test-only.
+func (m *Manager) EndpointsForTest() map[string]*hcn.HostComputeEndpoint {
+	return m.vmEndpoints
+}
+
+// IsNamespaceSupportedForTest returns the cached namespace-support flag. Test-only.
+func (m *Manager) IsNamespaceSupportedForTest() bool {
+	return m.isNamespaceSupportedByGuest
+}
+
+// AddEndpointToGuestNamespaceForTest exposes addEndpointToGuestNamespace for testing.
+func (m *Manager) AddEndpointToGuestNamespaceForTest(ctx context.Context, nicID string, endpoint *hcn.HostComputeEndpoint, policyBasedRouting bool) error {
+	return m.addEndpointToGuestNamespace(ctx, nicID, endpoint, policyBasedRouting)
+}
+
+// RemoveEndpointFromGuestNamespaceForTest exposes removeEndpointFromGuestNamespace for testing.
+func (m *Manager) RemoveEndpointFromGuestNamespaceForTest(ctx context.Context, nicID string, endpoint *hcn.HostComputeEndpoint) error {
+	return m.removeEndpointFromGuestNamespace(ctx, nicID, endpoint)
+}
+
+// AddNetNSInsideGuestForTest exposes addNetNSInsideGuest for testing.
+func (m *Manager) AddNetNSInsideGuestForTest(ctx context.Context, ns *hcn.HostComputeNamespace) error {
+	return m.addNetNSInsideGuest(ctx, ns)
+}

internal/controller/network/helpers_wcow_test.go

@@ -0,0 +1,42 @@
+//go:build windows && wcow
+
+package network_test
+
+import (
+	"errors"
+	"testing"
+
+	"github.com/Microsoft/hcsshim/internal/controller/network"
+	netmock "github.com/Microsoft/hcsshim/internal/controller/network/mock"
+	gcsmock "github.com/Microsoft/hcsshim/internal/gcs/mock"
+
+	"go.uber.org/mock/gomock"
+)
+
+var errTest = errors.New("test error")
+
+// newWCOWTestManager creates a Manager wired with WCOW mock dependencies.
+func newWCOWTestManager(t *testing.T, ctrl *gomock.Controller, namespaceSupportEnabled bool) (
+	*network.Manager,
+	*netmock.MockvmNetworkManager,
+	*netmock.MocklinuxGuestNetworkManager,
+	*netmock.MockwindowsGuestNetworkManager,
+) {
+	t.Helper()
+
+	mockVM := netmock.NewMockvmNetworkManager(ctrl)
+	mockLinuxGuest := netmock.NewMocklinuxGuestNetworkManager(ctrl)
+	mockWinGuest := netmock.NewMockwindowsGuestNetworkManager(ctrl)
+	mockCaps := netmock.NewMockcapabilitiesProvider(ctrl)
+
+	if namespaceSupportEnabled {
+		mockGuestCaps := gcsmock.NewMockGuestDefinedCapabilities(ctrl)
+		mockGuestCaps.EXPECT().IsNamespaceAddRequestSupported().Return(true)
+		mockCaps.EXPECT().Capabilities().Return(mockGuestCaps)
+	} else {
+		mockCaps.EXPECT().Capabilities().Return(nil)
+	}
+
+	m := network.New(mockVM, mockLinuxGuest, mockWinGuest, mockCaps)
+	return m, mockVM, mockLinuxGuest, mockWinGuest
+}

internal/controller/network/interface.go

@@ -2,6 +2,8 @@
 
 package network
 
+//go:generate go tool mockgen -source=interface.go -build_constraint=windows -package=mock -destination=mock/mock_network.go
+
 import (
 	"context"