Repository navigation
Commit 1be4ff4
FindRe2: use re2's package config, whose re2::re2 links abseil
Summary:
`FindRe2.cmake` finds re2 with `find_library()`, which gets only re2 itself. A static re2, such as the one vcpkg builds for eden's Windows build, also needs the abseil libraries it was built against, so linking `edenfs.exe` fails with 48 unresolved `absl::` symbols from `re2.lib`. re2's package config defines `re2::re2` with them, so `FindRe2` now uses that target when re2 has a config, as HHVM's and Velox's builds already do, and still falls back to `find_library()` when it doesn't.
___
landed-with-radar-review
Differential Revision: D128886633
fbshipit-source-id: 1337eb976bc27879fb1badd2bb770a65d5cc47a41 parent 57660d9 commit 1be4ff4
1 file changed
Lines changed: 8 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3 | 3 | | |
4 | 4 | | |
5 | 5 | | |
6 | | - | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
7 | 14 | | |
8 | 15 | | |
9 | 16 | | |
| |||
0 commit comments