I have opened several pull requests fixing many tiny issues that shouldn't have been made in first place - I suspect this is not because of incompetence but rather because of an incorrectly configured compiler that allows non standard compliant code to compile.
While the game may compile just fine with that specific compiler it makes the code incredibly unportable and also potentially ambiguous for future compiler versions or other compilers.
I suggest just throwing GCC at it, since GCC by default has very extensive checks for code that isn't standard compliant. It has actually found all these issues I have opened pull requests for (and there are many more!).
Also, the syntax is very inconsistent. But that's something IDE auto-formatting could easily solve.
Otherwise, great work. Keep it up!
I have opened several pull requests fixing many tiny issues that shouldn't have been made in first place - I suspect this is not because of incompetence but rather because of an incorrectly configured compiler that allows non standard compliant code to compile.
While the game may compile just fine with that specific compiler it makes the code incredibly unportable and also potentially ambiguous for future compiler versions or other compilers.
I suggest just throwing GCC at it, since GCC by default has very extensive checks for code that isn't standard compliant. It has actually found all these issues I have opened pull requests for (and there are many more!).
Also, the syntax is very inconsistent. But that's something IDE auto-formatting could easily solve.
Otherwise, great work. Keep it up!