ci(#11194): introduce CI failure analysis script#11195
Conversation
dianabarsan
changed the title
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Introduce a `--job` flag, allowing users to scan specific CI jobs by name or pattern, accelerating test failure analysis by bypassing logs from unrelated suites.
|
@jkuester this is the script I referred to in the call last week. I've been using it locally very successfully. The GH workflow is a WIP but without having it in |
jkuester
left a comment
jkuester
left a comment
There was a problem hiding this comment.
LGTM (sorry for the delayed review)! Some minor comments inline, but all in all this is very useful! I tested locally and it works as expected.
I will say that if we want to continue building similar scripts I would prefer it if we had a more structured approach. Dumping everything in a one-off script like this is not easy to maintain. Even the current release-notes script is really annoying and this one is 50% longer. 😓 40+ top-level functions in a single module is a nightmare to read through. At a certain point, my brain shut off and I gave up trying to track the flow through all the levels.... (Also, I think 500 lines is my new JS limit. 😅 Anything more than that should be TS. Trying to keep the mental context of the shape of all the data flowing around here was impossible.)
FWIW, the main goal behind the structuring of https://github.com/jkuester/chtoolbox was that it could be a framework for one-off scripts like this where it takes care of things like cli args, etc while also allowing for re-use of common services (like interacting with GitHub). I have been hesitant pull that into the medic org because there has not been universal buy-in on the Effect framework. 😬 But maybe in the brave new AI world that is less of a problem for folks. 🤷 Alternatively, we could just green-field a new non-Effect repo with similar goals......
- replace hand-rolled CLI parsing with node:util parseArgs - hardcode maxBuffer in runGh instead of a never-used option - move build.yml-coupled job-name constants to the top of the file - drop unused module exports and the require.main guard Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Remove this commit before merging to master. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
|
I added a temporary trigger (this is needed to be able to run the workout pre-main-merge). |
3 participants
Description
Claude wrote the script.
#11194
Code review checklist
can_view_old_navigationpermission to see the old design. Test it has appropriate design for RTL languages.Compose URLs
If Build CI hasn't passed, these may 404:
License
The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.