Interceptor preference and plugin disabled="true" attribute stopped working

[webloft]

Summary

For some reason our <preference/> does not work anymore after magento patch.2.4.6p14, so we started troubleshooting...

We don't know if it's only affected to the version, it started with updating the codebase - maybe another component is involved. We experienced that behavior on 2 different projects.

So far

• preference for interfaces seems to work (of course that would break anything otherwise)
• preference to override a simple class does not
• new plugins are working
• disabled="true" didn't work on existing plugins, now it does without change - strange

Magento does not complain about the preference at compilation time and it shows the preference registered by di:info command, yet the original class is now loaded, not the preference as it did before.

Examples

The preference we need to override (because it's buggy) is:

Magento\Tax\Model\Sales\Total\Quote\CommonTaxCollector

The other example is a simple plugin on load() of

Magento\Catalog\Model\ResourceModel\Product\Collection

Yeah, it may work in a vanilla empty instance - we didn't test it, also this doesn't help much - we want to know what probably could be broken or has changed.

Could someone please respond if there are breaking changes to this topic?

Edit:

Proposed solution

No response

Release note

No response

Triage and priority

• Severity: S0 - Affects critical data or functionality and leaves users without workaround.
• Severity: S1 - Affects critical data or functionality and forces users to employ a workaround.
• Severity: S2 - Affects non-critical data or functionality and forces users to employ a workaround.
• Severity: S3 - Affects non-critical data or functionality and does not force users to employ a workaround.
• Severity: S4 - Affects aesthetics, professional look and feel, “quality” or “usability”.

[m2-assistant]

Hi @webloft. Thank you for your report.
To speed up processing of this issue, make sure that the issue is reproducible on the vanilla Magento instance following Steps to reproduce.

• For more details, review the Magento Contributor Assistant documentation.
• Add a comment to assign the issue: @magento I am working on this
• To learn more about issue processing workflow, refer to the Code Contributions.

---

Join Magento Community Engineering Slack and ask your questions in #github channel.
⚠️ According to the Magento Contribution requirements, all issues must go through the Community Contributions Triage process. Community Contributions Triage is a public meeting.
🕙 You can find the schedule on the Magento Community Calendar page.
📞 The triage of issues happens in the queue order. If you want to speed up the delivery of your contribution, join the Community Contributions Triage session to discuss the appropriate ticket.

[github-jira-sync-bot]

✅ Jira issue https://jira.corp.adobe.com/browse/AC-16769 is successfully created for this GitHub issue.

[webloft]

???

disabled="true" suddenly works TODAY, but didn't yesterday? What could survive the command:

rm -rf generated/ && php bin/magento se:di:co

OPcache is only set to 2 seconds...

However, the preference is still not working.