Skip to content

Kompari xtask (html report, interactive test blessing, dead snapshots detection) #272

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spirali merged 13 commits into from
Apr 24, 2025
Merged

Kompari xtask (html report, interactive test blessing, dead snapshots detection) #272

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
28f049c
Added xtask into Parley; integrates kompari
spirali Feb 9, 2025
ed06985
Readme updated
spirali Feb 12, 2025
e4664af
Update parley/tests/README.md
spirali Feb 13, 2025
438ac2f
Added missing file
spirali Feb 13, 2025
bec2d2d
Reformated by Taplo
spirali Feb 13, 2025
ec437c6
Docs fixed
spirali Feb 13, 2025
52ad621
Fixed copyright header
spirali Feb 13, 2025
60cac02
Fixed missing attributes in Cargo.toml
spirali Feb 13, 2025
3b22bf5
xtask publish & version
spirali Feb 16, 2025
ef87e89
Taplo format
spirali Mar 25, 2025
aaaf89a
Updated version of Kompari
spirali Apr 23, 2025
903f4cc
Disable xtask in andoid builds
spirali Apr 23, 2025
bec9d98
CI update
spirali Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions .cargo/config.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
[alias]
xtask = "run --release --package xtask --"
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,10 +155,10 @@ jobs:
save-if: ${{ github.event_name != 'merge_group' }}

- name: cargo clippy
run: cargo hack clippy --workspace --locked --target ${{ matrix.target }} --optional-deps --each-feature --ignore-unknown-features --features std -- -D warnings
run: cargo hack clippy --package parley --package fontique --locked --target ${{ matrix.target }} --optional-deps --each-feature --ignore-unknown-features --features std -- -D warnings
Copy link
Copy Markdown
Member

@DJMcNab DJMcNab Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm. Why do we want to not run clippy on the xtask code itself? Is it just how much longer it takes (since it needs to check axum, etc.), or something else?

Copy link
Copy Markdown
Contributor Author

@spirali spirali Apr 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am disabling it only for andoid, as kompari does not compile there because of:

     Compiling libdeflate-sys v1.23.1
  warning: libdeflate-sys@1.23.1: Compiler family detection failed due to error: ToolNotFound: failed to find tool "x86_64-linux-android-clang": No such file or directory (os error 2)
  error: failed to run custom build command for `libdeflate-sys v1.23.1`

Copy link
Copy Markdown
Member

@DJMcNab DJMcNab Apr 23, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah - that's unfortunate, but not too important at the moment.

Can this instead be --workspace --exclude xtask?

Copy link
Copy Markdown
Contributor Author

@spirali spirali Apr 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I was looking for something like this in the documentation and could not find it so I have named the packages.


- name: cargo clippy (auxiliary)
run: cargo hack clippy --workspace --locked --target ${{ matrix.target }} --optional-deps --each-feature --ignore-unknown-features --features std --tests --benches --examples -- -D warnings
run: cargo hack clippy --package parley --package fontique --locked --target ${{ matrix.target }} --optional-deps --each-feature --ignore-unknown-features --features std --tests --benches --examples -- -D warnings

prime-lfs-cache:
name: Prime LFS Cache
Expand Down Expand Up @@ -289,7 +289,7 @@ jobs:
save-if: ${{ github.event_name != 'merge_group' }}

- name: cargo check
run: cargo hack check ${{ env.RUST_MIN_VER_PKGS }} --locked --target ${{ matrix.target }} --optional-deps --each-feature --ignore-unknown-features --features std
run: cargo hack check --package parley --package fontique ${{ env.RUST_MIN_VER_PKGS }} --locked --target ${{ matrix.target }} --optional-deps --each-feature --ignore-unknown-features --features std

doc:
name: cargo doc
Expand Down
Loading
Loading