Skip to content

Split VelloAsset into VelloSvg and VelloLottie#90

Merged
nuzzles merged 23 commits into
mainfrom
simbleau/issue-89
Feb 6, 2025
Merged

Split VelloAsset into VelloSvg and VelloLottie#90
nuzzles merged 23 commits into
mainfrom
simbleau/issue-89

Conversation

@nuzzles
Copy link
Copy Markdown
Member

@nuzzles nuzzles commented Dec 12, 2024

Builds upon #87. Merge that first.

Closes #89.

@nuzzles nuzzles changed the title Simbleau/issue-89 Split VelloAsset into VelloSvg and VelloLottie Dec 12, 2024
@nuzzles nuzzles requested review from DJMcNab and sebasjham February 4, 2025 04:22
Copy link
Copy Markdown
Contributor

@Fliqqr Fliqqr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@nuzzles nuzzles added this pull request to the merge queue Feb 6, 2025
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Feb 6, 2025
@nuzzles
Copy link
Copy Markdown
Member Author

nuzzles commented Feb 6, 2025

Failed merging due to bevyengine/bevy#17699, which is unrelated to the PR.

I created a new PR to unblock merging: #103

github-merge-queue Bot pushed a commit that referenced this pull request Feb 6, 2025
Our pipeline in #90 is unable to merge due to
bevyengine/bevy#17699

This PR fixes the issue with a workaround. Stage the Cargo.lock, and fix
the transitive dependency on getrandom.

Dually Closes #91 and unblocks #90
@nuzzles nuzzles added this pull request to the merge queue Feb 6, 2025
Merged via the queue into main with commit 08ca628 Feb 6, 2025
@nuzzles nuzzles deleted the simbleau/issue-89 branch February 6, 2025 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Split VelloAsset into VelloSvg and VelloLottie.

4 participants