LP-567 fix spurious Settings node expand when selecting a Data item

was due a regression in the parent() method

Author: filnet

ground/gcs/src/plugins/uavobjectbrowser/uavobjecttreemodel.cpp

@@ -295,11 +295,10 @@ QModelIndex UAVObjectTreeModel::parent(const QModelIndex &index) const
         return QModelIndex();
     }
 
-    TreeItem *item = static_cast<TreeItem *>(index.internalPointer());
+    TreeItem *childItem  = static_cast<TreeItem *>(index.internalPointer());
+    TreeItem *parentItem = childItem->parent();
 
-    TreeItem *parentItem = item->parent();
-    if (!parentItem) {
-        // item is root has no parent...
+    if (parentItem == m_rootItem) {
         return QModelIndex();
     }