Skip to content

Commit 5ecf3f2

Browse files
committed
LP-551 Switch - break cleanup
1 parent 9787bee commit 5ecf3f2

1 file changed

Lines changed: 2 additions & 6 deletions

File tree

ground/gcs/src/plugins/config/configoutputwidget.cpp

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -630,17 +630,14 @@ ConfigOutputWidget::ChannelConfigWarning ConfigOutputWidget::checkChannelConfig(
630630
switch (bankControls->modeCombo()->currentIndex()) {
631631
case ActuatorSettings::BANKMODE_DSHOT:
632632
if (channelForm->isServoOutput()) {
633+
// Driving a servo using DShot doest not make sense
633634
warning = CannotDriveServo;
634-
// Driving a servo using DShot doest not make sense so break
635-
break;
636-
}
637-
if (channelForm->isReversableMotor()) {
635+
} else if (channelForm->isReversableMotor()) {
638636
// Bi-directional DShot not yet supported
639637
warning = BiDirectionalDShotNotSupported;
640638
}
641639
break;
642640
case ActuatorSettings::BANKMODE_PWMSYNC:
643-
break;
644641
case ActuatorSettings::BANKMODE_PWM:
645642
break;
646643
case ActuatorSettings::BANKMODE_ONESHOT125:
@@ -649,7 +646,6 @@ ConfigOutputWidget::ChannelConfigWarning ConfigOutputWidget::checkChannelConfig(
649646
if (channelForm->isServoOutput()) {
650647
warning = CannotDriveServo;
651648
// Driving a servo using this mode does not make sense so break
652-
break;
653649
}
654650
default:
655651
break;

0 commit comments

Comments
 (0)