-
Notifications
You must be signed in to change notification settings - Fork 0
Adopt camino/cap-std path types across the integration test suite #418
Copy link
Copy link
Open
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestmediumRoadmap items to schedule within the current quarter. Clear scope, normal review cycles.Roadmap items to schedule within the current quarter. Clear scope, normal review cycles.refactorBehaviour-preserving restructuring that improves code health.Behaviour-preserving restructuring that improves code health.
Description
Metadata
Metadata
Assignees
Labels
documentationImprovements or additions to documentationImprovements or additions to documentationenhancementNew feature or requestNew feature or requestmediumRoadmap items to schedule within the current quarter. Clear scope, normal review cycles.Roadmap items to schedule within the current quarter. Clear scope, normal review cycles.refactorBehaviour-preserving restructuring that improves code health.Behaviour-preserving restructuring that improves code health.
Context
During the review of #415 (broaden the static-regex lint guard, closes #410), CodeRabbit suggested migrating the new
tests/static_regex_lint.rsfromstd::path/std::fstocaminopath types andcap_std::fs_utf8APIs.This was deferred from that PR because doing it for one new test file in isolation would:
camino,cap-std) that are currently absent from the tree (Cargo.lockhas zero references), andstd::fs/std::pathandtempfile(for exampletests/cli.rs),so it fell outside the minimal-change scope of the lint fix.
Proposal
If UTF-8 path guarantees and capability-scoped filesystem access are desired, adopt them suite-wide rather than piecemeal:
caminoandcap-stdas dev-dependencies.tests/fromstd::path::{Path, PathBuf}tocamino::{Utf8Path, Utf8PathBuf}.std::fscalls withcap_std::fs_utf8equivalents, preserving existingCommandexecution andTempDirhandling.Please import the latest whitaker user's guide from
https://raw.githubusercontent.com/leynos/whitaker/refs/heads/main/docs/users-guide.mdasdocs/whitaker-users-guide.mdwhich covers the new whitaker functionality allowing suppression of the no_std_fs lint at the path level.Acceptance criteria
camino/cap-stdadded as dev-dependencies with a rationale recorded.Utf8Path/Utf8PathBufandcap_std::fs_utf8consistently, with no behavioural regressions.References