refactor(Analysis): golf Mathlib/Analysis/Analytic/OfScalars#38513
Open
yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Open
refactor(Analysis): golf Mathlib/Analysis/Analytic/OfScalars#38513yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Mathlib/Analysis/Analytic/OfScalars#38513yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
Conversation
yuanyi-350
added
codex
Collaborator
Author
|
!bench |
26 tasks
|
Benchmark results for a548273 against 36a9746 are in. No significant results found. @yuanyi-350
Small changes (2✅)
|
PR summary 36a97460d7Import changes for modified filesNo significant changes to the import graph Import changes for all files
Declarations diffNo declarations were harmed in the making of this PR! 🐙 You can run this locally as follows## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>
## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>The doc-module for Decrease in tech debt: (relative, absolute) = (2.00, 0.00)
Current commit 8b14f261d9 This script lives in the
|
Collaborator
Author
|
I ran a profiler comparison for the changed declarations in this PR. Results (seconds):
Overall:
|
yuanyi-350
added
the
tech debt
Comment on lines
+67
to
+68
| intro c c' h | ||
| funext n |
Collaborator
There was a problem hiding this comment.
too keep things close to before
Suggested change
| intro c c' h | |
| funext n | |
| intro _ _ h | |
| ext n |
Comment on lines
+89
to
+90
| ext n x | ||
| simp [ofScalars, add_smul] |
Collaborator
There was a problem hiding this comment.
to keep it consistent with some code before it
Suggested change
| ext n x | |
| simp [ofScalars, add_smul] | |
| ext; simp [ofScalars, add_smul] |
Comment on lines
+96
to
+97
| ext n y | ||
| simp [ofScalars, smul_smul] |
Collaborator
There was a problem hiding this comment.
Suggested change
| ext n y | |
| simp [ofScalars, smul_smul] | |
| ext; simp [ofScalars, smul_smul] |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ofScalars_series_injectiveby evaluating the equality on the constant1tupleofScalars_addandofScalars_smulwithext/simp, removing the transparency workaroundExtracted from #37968