Skip to content

[Merged by Bors] - refactor(Analysis): golf Mathlib/Analysis/Normed/Lp/lpSpace#38437

Closed
yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
yuanyi-350:A_8
Closed

[Merged by Bors] - refactor(Analysis): golf Mathlib/Analysis/Normed/Lp/lpSpace#38437
yuanyi-350 wants to merge 2 commits intoleanprover-community:masterfrom
yuanyi-350:A_8

Conversation

@yuanyi-350
Copy link
Copy Markdown
Collaborator

  • rewrites uniformContinuous_coe to use (lipschitzWith_one_eval (E := E) p i).uniformContinuous
  • removes the manual uniformContinuous_pi epsilon argument for the coordinate coercion

Extracted from #37968

Open in Gitpod

@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 24, 2026

PR summary 1c558eb49a

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## summary with just the declaration names:
./scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
./scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh contains some details about this script.


No changes to technical debt.

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@github-actions github-actions Bot added the t-analysis Analysis (normed *, calculus) label Apr 24, 2026
@yuanyi-350
Copy link
Copy Markdown
Collaborator Author

I ran a profiler comparison for the changed declaration in this PR.

Results (seconds):

  • lp.uniformContinuous_coe: 0.353174 -> 0.064573 (-81.71%)

Overall:

  • This PR substantially speeds up elaboration of lp.uniformContinuous_coe.
  • Both before and after elaborated successfully.
  • Times are from the top-level [Elab.async] elaborating proof of lp.uniformContinuous_coe profiler entry.

@yuanyi-350 yuanyi-350 added codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly labels Apr 24, 2026
@sgouezel
Copy link
Copy Markdown
Contributor

bors r+

@mathlib-triage mathlib-triage Bot added the ready-to-merge This PR has been sent to bors. label Apr 27, 2026
mathlib-bors Bot pushed a commit that referenced this pull request Apr 27, 2026
- rewrites `uniformContinuous_coe` to use `(lipschitzWith_one_eval (E := E) p i).uniformContinuous`
- removes the manual `uniformContinuous_pi` epsilon argument for the coordinate coercion

Extracted from #37968

[![Open in Gitpod](https://gitpod.io/button/open-in-gitpod.svg)](https://gitpod.io/from-referrer/)
@mathlib-bors
Copy link
Copy Markdown
Contributor

mathlib-bors Bot commented Apr 27, 2026

Pull request successfully merged into master.

Build succeeded:

@mathlib-bors mathlib-bors Bot changed the title refactor(Analysis): golf Mathlib/Analysis/Normed/Lp/lpSpace [Merged by Bors] - refactor(Analysis): golf Mathlib/Analysis/Normed/Lp/lpSpace Apr 27, 2026
@mathlib-bors mathlib-bors Bot closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex OpenAI Codex wrote (parts of) this PR. LLM-generated PRs with substantial input from LLMs - review accordingly ready-to-merge This PR has been sent to bors. t-analysis Analysis (normed *, calculus)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants