fix: Entity class_existsガード記事に回帰バグの追記を追加 - #121
Merged
Merged
Conversation
#6895 はマージ後に回帰バグ(#6963)が判明したため、公開済み記事の 事実誤認を訂正し追記セクションを新設する。 - TL;DR の「fatal が出ない状態にした」を訂正 - 「require_once が起きる4箇所」に5箇所目(doctrine-bundle の auto_mapping) が抜けていた旨を注記 - 末尾に「その後、回帰バグが見つかった」を新設。手元での再現結果、 #6963 で塞ぎきれない経路(報告済み: #6979)、revert 可能性を記載 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
公開済み記事
eccube44-entity-class-exists-guardに、事実誤認の訂正と追記を入れます。主題である EC-CUBE 本体 PR #6895 は、マージ後に回帰バグが判明しました(PR #6963)。記事の「ガードなしでも fatal が出ない状態にした」という記述が事実と異なります。
変更内容
require_onceが起きる4箇所」の表の直後に、5箇所目(doctrine-bundle のauto_mappingが生成する素のAttributeDriver)が抜けていた旨を注記追記セクションの内容
require_once)89dec55c49) を立てて再現させた結果の表記述はすべてローカル環境での再現結果に基づいています。
stop-ai-slop-jpによるチェック済みです。🤖 Generated with Claude Code