hide cat toogle in case only one cat is available#2599
Conversation
cc67bcc to
0716acc
Compare
ppadti
left a comment
There was a problem hiding this comment.
Thanks @Philip-Carneiro !!
one question - @mturley @Philip-Carneiro
when there's only 1 category the toggle is hidden, but now the user has no way to know which category they're viewing. Would it be better to show the name and description when we have 1 category or should we leave it as is, not sure.
|
+1 to Pushpa's suggestion - I think name and description should be there |
0716acc to
9f285d4
Compare
c073d6e to
31544d2
Compare
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
31544d2 to
b2d9a83
Compare
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
ppadti
left a comment
There was a problem hiding this comment.
Sorry @Philip-Carneiro for the back and forth. The fix for the useEffect guard and the singleCategoryLabel prop looks good on the Model Catalog side — could we mirror the same changes in McpCatalog.tsx and McpCatalogGalleryView.tsx as well?
Signed-off-by: Philip Colares Carneiro <philip.colares@gmail.com>
I add the change requested |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ppadti The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
When only one category is available for Model Catalog or MCP Catalog, the grid only show 4 cards and need to click in a link/toggle to show all the cards from that category.
These changes are made for when this happens, it shows all the cards available in that category (until the load more button appear)
getActiveSourceLabelsutility functionWith this changes the behaviour will be:
Before:
After:
How Has This Been Tested?
It was manually tested, also crated unit tests and 3 new cypress tests
Merge criteria:
DCOcheck)ok-to-testhas been added to the PR.If you have UI changes