Skip to content

fix(catalog): make NAME ordering case insensitive#2026

Open
Al-Pragliola wants to merge 1 commit intokubeflow:mainfrom
Al-Pragliola:al-pragliola-make-name-ordering-case-insensitive
Open

fix(catalog): make NAME ordering case insensitive#2026
Al-Pragliola wants to merge 1 commit intokubeflow:mainfrom
Al-Pragliola:al-pragliola-make-name-ordering-case-insensitive

Conversation

@Al-Pragliola
Copy link
Copy Markdown
Contributor

Description

How Has This Been Tested?

local and unit tests

Merge criteria:

  • All the commits have been signed-off (To pass the DCO check)
  • The commits have meaningful messages
  • Automated tests are provided as part of the PR for major new functionalities; testing instructions have been added in the PR body (for PRs involving changes that are not immediately obvious).
  • The developer has manually tested the changes and verified that the changes work.
  • Code changes follow the kubeflow contribution guidelines.
  • For first time contributors: Please reach out to the Reviewers to ensure all tests are being run, ensuring the label ok-to-test has been added to the PR.

@google-oss-prow google-oss-prow Bot requested a review from jonburdo December 17, 2025 20:31
@google-oss-prow
Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from al-pragliola. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link
Copy Markdown
Contributor

@dbasunag dbasunag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure if we should be using lexicographic sorting for strings like names. But whatever we decide, it needs to be documented and we need to be consistent across similar fields.

@github-actions
Copy link
Copy Markdown
Contributor

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Signed-off-by: Alessio Pragliola <seth.pro@gmail.com>
@Al-Pragliola Al-Pragliola force-pushed the al-pragliola-make-name-ordering-case-insensitive branch from 7e44fc9 to fc0a62f Compare March 20, 2026 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants