fix #4714: surface skip reason during kpt live plan - #4721
Closed
adi-coderr wants to merge 2 commits into
Closed
Conversation
Resolves the TODO in live plan to provide context when resources are skipped by mapping skipped statuses with their associated error messages from cli-utils. Signed-off-by: Aditya <ntgmuch01@gmail.com>
adi-coderr
requested review from
efiacor,
kispaljr,
liamfallon and
mozesl-nokia
as code owners
August 31, 2026 18:38
✅ Deploy Preview for kptdocs ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Signed-off-by: Aditya <ntgmuch01@gmail.com>
adi-coderr
force-pushed
the
fix-live-plan-skip
branch
from
September 1, 2026 16:51
267fb8f to
7e51c01
Compare
Contributor
|
Hi @adi-coderr |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
kpt live planwhen a resource evaluates to a skipped action, and updated the corresponding unit tests to reflect the new expected stdout.=sign without any context, leaving developers and operators guessing if it was a configuration error, an intentional lifecycle hook, or a bug. This also resolves an existingTODOincommands/alpha/live/plan/command.go.kptplanner.Skipcases to extract and print the specific skip reason from the action context. Updated the expected stdout assertions incommands/alpha/live/plan/command_test.goto match the newly added strings.Type of Change
Checklist
AI Disclosure
If so, please describe how:
cli-utilslifecycle hooks, isolate the specifickptplanner.Skipedge cases (such as deletion detachments) for manual validation, and structure the localized end-to-end testing environment.