Conversation
- [`persist-credentials: false`](https://docs.zizmor.sh/audits/#artipacked) - [pinning `uses`](https://docs.zizmor.sh/audits/#unpinned-uses) I've focused only on our custom CI configuration, not on the CI configuration from upstream: I'm not even sure whether we run the upstream configuration, and even if we do, I'd prefer not to introduce changes (fairly invasive ones in some cases!) that might lead to merge conflicts. Ideally we'd do better someday, including trying to make changes upstream.
Collaborator
Author
It looks like we "Prepare" but do nothing else: Now presumably it would be nice to pin actions for that step and perhaps make other changes. Or we could delete that configuration entirely (at the cost of having to tell Git to ignore changes to those deleted files when we see merge conflicts). |
msridhar
reviewed
Aug 8, 2026
| JAVA_VERSION: 24 | ||
| steps: | ||
| - uses: actions/checkout@v4 | ||
| - uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262 |
Collaborator
There was a problem hiding this comment.
I think zizmor can add a comment for what version the SHA corresponds to?
Also, do we want to switch to a more recent version of this action while we're at it?
| persist-credentials: false | ||
| - name: Set up JDK 24 | ||
| uses: actions/setup-java@v4 | ||
| uses: actions/setup-java@c1e323688fd81a25caa38c78aa6df2d33d3e20d9 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
persist-credentials: falseusesI've focused only on our custom CI configuration, not on the CI configuration from upstream: I'm not even sure whether we run the upstream configuration, and even if we do, I'd prefer not to introduce changes (fairly invasive ones in some cases!) that might lead to merge conflicts. Ideally we'd do better someday, including trying to make changes upstream.