Skip to content

Commit d375791

Browse files
gredrian08gcueto-algmjongpie
authored
Bugfix: Modal Close Buttons Not Rendered Correctly (#937)
* Fixed #936 by removing some SLDS classes from the modal X close buttons in several LWCs so the X is properly rendered --------- Co-authored-by: Gredrian Cueto <gcueto@allegromicro.com> Co-authored-by: Jonathan Gillespie <jonathan.c.gillespie@gmail.com>
1 parent 57ffd2c commit d375791

8 files changed

Lines changed: 19 additions & 18 deletions

File tree

‎README.md‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,13 +5,13 @@
55

66
The most robust observability solution for Salesforce experts. Built 100% natively on the platform, and designed to work seamlessly with Apex, Lightning Components, Flow, OmniStudio, and integrations.
77

8-
## Unlocked Package - v4.17.1
8+
## Unlocked Package - v4.17.2
99

10-
[![Install Unlocked Package in a Sandbox](./images/btn-install-unlocked-package-sandbox.png)](https://test.salesforce.com/packaging/installPackage.apexp?p0=04tg7000000157JAAQ)
11-
[![Install Unlocked Package in Production](./images/btn-install-unlocked-package-production.png)](https://login.salesforce.com/packaging/installPackage.apexp?p0=04tg7000000157JAAQ)
10+
[![Install Unlocked Package in a Sandbox](./images/btn-install-unlocked-package-sandbox.png)](https://test.salesforce.com/packaging/installPackage.apexp?p0=04tg700000015gnAAA)
11+
[![Install Unlocked Package in Production](./images/btn-install-unlocked-package-production.png)](https://login.salesforce.com/packaging/installPackage.apexp?p0=04tg700000015gnAAA)
1212
[![View Documentation](./images/btn-view-documentation.png)](https://github.com/jongpie/NebulaLogger/wiki)
1313

14-
`sf package install --wait 20 --security-type AdminsOnly --package 04tg7000000157JAAQ`
14+
`sf package install --wait 20 --security-type AdminsOnly --package 04tg700000015gnAAA`
1515

1616
---
1717

‎nebula-logger/core/main/log-management/lwc/logEntryMetadataViewer/logEntryMetadataViewer.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,8 @@
5151
<div class="slds-modal__container" onkeydown={handleKeyDown}>
5252
<!-- Modal header -->
5353
<header class="slds-modal__header">
54-
<button class="slds-button slds-button_icon slds-modal__close slds-button_icon-inverse" title="Close" onclick={handleHideFullSourceMetadataModal}>
55-
<lightning-icon icon-name="utility:close" alternative-text="close" variant="inverse" size="small"></lightning-icon>
54+
<button class="slds-button slds-button_icon slds-modal__close" title="Close" onclick={handleHideFullSourceMetadataModal}>
55+
<lightning-icon icon-name="utility:close" alternative-text="close" size="small"></lightning-icon>
5656
</button>
5757
<h2 class="slds-text-heading_medium slds-hyphenate">{fullSourceMetadataTitle}</h2>
5858
</header>

‎nebula-logger/core/main/log-management/lwc/loggerHomeHeader/loggerHomeHeader.html‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -56,8 +56,8 @@ <h1>
5656
<div class="slds-modal__container" onkeydown={handleKeyDown}>
5757
<!-- Modal header -->
5858
<header class="slds-modal__header">
59-
<button class="slds-button slds-button_icon slds-modal__close slds-button_icon-inverse" title="Close" onclick={handleCloseEnvironmentDetailsModal}>
60-
<lightning-icon icon-name="utility:close" alternative-text="close" variant="inverse" size="small"></lightning-icon>
59+
<button class="slds-button slds-button_icon slds-modal__close" title="Close" onclick={handleCloseEnvironmentDetailsModal}>
60+
<lightning-icon icon-name="utility:close" alternative-text="close" size="small"></lightning-icon>
6161
</button>
6262
<h2 class="slds-text-heading_medium slds-hyphenate" data-id="environment-details-modal-title">Environment Details</h2>
6363
</header>

‎nebula-logger/core/main/log-management/lwc/loggerSettings/loggerSettings.html‎

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -44,8 +44,8 @@
4444
<div class="slds-modal__container" onkeydown={handleKeyDown}>
4545
<!-- Record modal header -->
4646
<header class="slds-modal__header">
47-
<button class="slds-button slds-button_icon slds-modal__close slds-button_icon-inverse" title="Close" onclick={closeRecordModal}>
48-
<lightning-icon icon-name="utility:close" alternative-text="close" variant="inverse" size="small"></lightning-icon>
47+
<button class="slds-button slds-button_icon slds-modal__close" title="Close" onclick={closeRecordModal}>
48+
<lightning-icon icon-name="utility:close" alternative-text="close" size="small"></lightning-icon>
4949
</button>
5050
<h2 class="slds-text-heading_medium slds-hyphenate">Logger Settings Details</h2>
5151
</header>
@@ -319,8 +319,8 @@ <h2 class="slds-text-heading_medium slds-hyphenate">Logger Settings Details</h2>
319319
<div class="slds-modal__container" onkeydown={handleKeyDown}>
320320
<!-- Delete modal header -->
321321
<header class="slds-modal__header">
322-
<button class="slds-button slds-button_icon slds-modal__close slds-button_icon-inverse" title="Close" onclick={closeDeleteModal}>
323-
<lightning-icon icon-name="utility:close" alternative-text="close" variant="inverse" size="small"></lightning-icon>
322+
<button class="slds-button slds-button_icon slds-modal__close" title="Close" onclick={closeDeleteModal}>
323+
<lightning-icon icon-name="utility:close" alternative-text="close" size="small"></lightning-icon>
324324
</button>
325325

326326
<h2 class="slds-text-heading_medium slds-hyphenate">Delete Logger Settings Record</h2>

‎nebula-logger/core/main/logger-engine/classes/Logger.cls‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
global with sharing class Logger {
1616
// There's no reliable way to get the version number dynamically in Apex
1717
@TestVisible
18-
private static final String CURRENT_VERSION_NUMBER = 'v4.17.1';
18+
private static final String CURRENT_VERSION_NUMBER = 'v4.17.2';
1919
private static final System.LoggingLevel FALLBACK_LOGGING_LEVEL = System.LoggingLevel.DEBUG;
2020
private static final List<LogEntryEventBuilder> LOG_ENTRIES_BUFFER = new List<LogEntryEventBuilder>();
2121
private static final String MISSING_SCENARIO_ERROR_MESSAGE = 'No logger scenario specified. A scenario is required for logging in this org.';

‎nebula-logger/core/main/logger-engine/lwc/logger/loggerService.js‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ import LoggerServiceTaskQueue from './loggerServiceTaskQueue';
1010
import getSettings from '@salesforce/apex/ComponentLogger.getSettings';
1111
import saveComponentLogEntries from '@salesforce/apex/ComponentLogger.saveComponentLogEntries';
1212

13-
const CURRENT_VERSION_NUMBER = 'v4.17.1';
13+
const CURRENT_VERSION_NUMBER = 'v4.17.2';
1414

1515
const CONSOLE_OUTPUT_CONFIG = {
1616
messagePrefix: `%c Nebula Logger ${CURRENT_VERSION_NUMBER} `,

‎package.json‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
{
22
"name": "nebula-logger",
3-
"version": "4.17.1",
3+
"version": "4.17.2",
44
"description": "The most robust logger for Salesforce. Works with Apex, Lightning Components, Flow, Process Builder & Integrations. Designed for Salesforce admins, developers & architects.",
55
"author": "Jonathan Gillespie",
66
"license": "MIT",

‎sfdx-project.json‎

Lines changed: 4 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -9,9 +9,9 @@
99
"path": "./nebula-logger/core",
1010
"definitionFile": "./config/scratch-orgs/base-scratch-def.json",
1111
"scopeProfiles": true,
12-
"versionNumber": "4.17.1.NEXT",
13-
"versionName": "Bugfix: Allowing to log SObject without ID field",
14-
"versionDescription": "Updated LogEntryEventBuilder to handle the few types of SObjects that do not have an Id field (most notably, Platform Events)",
12+
"versionNumber": "4.17.2.NEXT",
13+
"versionName": "Bugfix: Modal Close Buttons Not Rendered Correctly",
14+
"versionDescription": "Removed some SLDS classes from the modal X close buttons in several LWCs to the X is properly rendered",
1515
"postInstallUrl": "https://github.com/jongpie/NebulaLogger/wiki",
1616
"releaseNotesUrl": "https://github.com/jongpie/NebulaLogger/releases",
1717
"unpackagedMetadata": {
@@ -223,6 +223,7 @@
223223
"Nebula Logger - Core@4.16.5-capture-apex-cursor-transaction-limits": "04tKe0000011N4KIAU",
224224
"Nebula Logger - Core@4.17.0-summer-'25-release": "04tg70000000rNhAAI",
225225
"Nebula Logger - Core@4.17.1-bugfix:-allowing-to-log-sobject-without-id-field": "04tg7000000157JAAQ",
226+
"Nebula Logger - Core@4.17.2-bugfix:-modal-close-buttons-not-rendered-correctly": "04tg700000015gnAAA",
226227
"Nebula Logger - Core Plugin - Async Failure Additions": "0Ho5Y000000blO4SAI",
227228
"Nebula Logger - Core Plugin - Async Failure Additions@1.0.0": "04t5Y0000015lhiQAA",
228229
"Nebula Logger - Core Plugin - Async Failure Additions@1.0.1": "04t5Y0000015lhsQAA",

0 commit comments

Comments
 (0)