Origin Location Parsing Improvement (#872)

* Slight tweak to origin location stack trace parsing in Apex to improve how origin location is displayed

Author: jamessimone

README.md

@@ -5,13 +5,13 @@
 
 The most robust observability solution for Salesforce experts. Built 100% natively on the platform, and designed to work seamlessly with Apex, Lightning Components, Flow, OmniStudio, and integrations.
 
-## Unlocked Package - v4.16.1
+## Unlocked Package - v4.16.2
 
-[![Install Unlocked Package in a Sandbox](./images/btn-install-unlocked-package-sandbox.png)](https://test.salesforce.com/packaging/installPackage.apexp?p0=04tKe0000011MXEIA2)
-[![Install Unlocked Package in Production](./images/btn-install-unlocked-package-production.png)](https://login.salesforce.com/packaging/installPackage.apexp?p0=04tKe0000011MXEIA2)
+[![Install Unlocked Package in a Sandbox](./images/btn-install-unlocked-package-sandbox.png)](https://test.salesforce.com/packaging/installPackage.apexp?p0=04tKe0000011Mi9IAE)
+[![Install Unlocked Package in Production](./images/btn-install-unlocked-package-production.png)](https://login.salesforce.com/packaging/installPackage.apexp?p0=04tKe0000011Mi9IAE)
 [![View Documentation](./images/btn-view-documentation.png)](https://github.com/jongpie/NebulaLogger/wiki)
 
-`sf package install --wait 20 --security-type AdminsOnly --package 04tKe0000011MXEIA2`
+`sf package install --wait 20 --security-type AdminsOnly --package 04tKe0000011Mi9IAE`
 
 ---
 

nebula-logger/core/main/logger-engine/classes/LogEntryEventBuilder.cls

@@ -510,7 +510,7 @@ global with sharing class LogEntryEventBuilder {
    * @return                  The same instance of `LogEntryEventBuilder`, useful for chaining methods
    */
   global LogEntryEventBuilder setRecord(Map<Id, SObject> recordIdToRecord) {
-    if (this.shouldSave == false) {
+    if (this.shouldSave() == false) {
       return this;
     }
 

nebula-logger/core/main/logger-engine/classes/Logger.cls

@@ -15,7 +15,7 @@
 global with sharing class Logger {
   // There's no reliable way to get the version number dynamically in Apex
   @TestVisible
-  private static final String CURRENT_VERSION_NUMBER = 'v4.16.1';
+  private static final String CURRENT_VERSION_NUMBER = 'v4.16.2';
   private static final System.LoggingLevel FALLBACK_LOGGING_LEVEL = System.LoggingLevel.DEBUG;
   private static final List<LogEntryEventBuilder> LOG_ENTRIES_BUFFER = new List<LogEntryEventBuilder>();
   private static final String MISSING_SCENARIO_ERROR_MESSAGE = 'No logger scenario specified. A scenario is required for logging in this org.';

nebula-logger/core/main/logger-engine/classes/LoggerStackTrace.cls

@@ -134,6 +134,10 @@ public without sharing class LoggerStackTrace {
     }
 
     String firstStackTraceLine = cleansedStackTraceLines.get(0);
+    if (firstStackTraceLine == 'External entry point' && cleansedStackTraceLines.size() > 1) {
+      firstStackTraceLine = cleansedStackTraceLines.get(1);
+    }
+
     String cleanedLocation = firstStackTraceLine;
     if (cleanedLocation.contains(':')) {
       cleanedLocation = cleanedLocation.substringBefore(':');

nebula-logger/core/main/logger-engine/lwc/logger/loggerService.js

@@ -10,7 +10,7 @@ import LoggerServiceTaskQueue from './loggerServiceTaskQueue';
 import getSettings from '@salesforce/apex/ComponentLogger.getSettings';
 import saveComponentLogEntries from '@salesforce/apex/ComponentLogger.saveComponentLogEntries';
 
-const CURRENT_VERSION_NUMBER = 'v4.16.1';
+const CURRENT_VERSION_NUMBER = 'v4.16.2';
 
 const CONSOLE_OUTPUT_CONFIG = {
   messagePrefix: `%c  Nebula Logger ${CURRENT_VERSION_NUMBER}  `,

nebula-logger/core/tests/logger-engine/classes/LoggerStackTrace_Tests.cls

@@ -237,6 +237,34 @@ private class LoggerStackTrace_Tests {
     System.Assert.isNull(stackTrace.Source);
   }
 
+  @IsTest
+  static void it_should_ignore_external_entry_point_stack_trace_line() {
+    String externalEntryPointStackTrace = 'External entry point';
+    String mockStackTrace = externalEntryPointStackTrace + '\n' + 'Class.SomeClass.someMethod: line 1, column 1';
+
+    LoggerStackTrace stackTrace = new LoggerStackTrace(mockStackTrace);
+
+    System.Assert.areEqual(LoggerStackTrace.SourceLanguage.Apex, stackTrace.Language);
+    System.Assert.areEqual('SomeClass.someMethod', stackTrace.Location);
+    System.Assert.areEqual(mockStackTrace, stackTrace.ParsedStackTraceString);
+  }
+
+  @IsTest
+  static void it_should_not_skip_external_entry_point_stack_trace_line_in_middle_of_stack_trace() {
+    String externalEntryPointStackTrace = 'External entry point';
+    String mockStackTrace =
+      'Class.SomeClass.someMethod: line 1, column 1' +
+      '\n' +
+      externalEntryPointStackTrace +
+      'Class.SomeOtherClass.someMethod: line 1, column 1';
+
+    LoggerStackTrace stackTrace = new LoggerStackTrace(mockStackTrace);
+
+    System.Assert.areEqual(LoggerStackTrace.SourceLanguage.Apex, stackTrace.Language);
+    System.Assert.areEqual('SomeClass.someMethod', stackTrace.Location);
+    System.Assert.isTrue(stackTrace.ParsedStackTraceString.contains(externalEntryPointStackTrace));
+  }
+
   private class DebugStringExample {
     private System.Exception constructorStackTraceGenerator;
     private System.Exception methodStackTraceGenerator;

package.json

@@ -1,6 +1,6 @@
 {
   "name": "nebula-logger",
-  "version": "4.16.1",
+  "version": "4.16.2",
   "description": "The most robust logger for Salesforce. Works with Apex, Lightning Components, Flow, Process Builder & Integrations. Designed for Salesforce admins, developers & architects.",
   "author": "Jonathan Gillespie",
   "license": "MIT",

sfdx-project.json

@@ -9,9 +9,9 @@
       "path": "./nebula-logger/core",
       "definitionFile": "./config/scratch-orgs/base-scratch-def.json",
       "scopeProfiles": true,
-      "versionNumber": "4.16.1.NEXT",
-      "versionName": "Data Masking & String Truncation Improvements",
-      "versionDescription": "Fixed several issues with the included data masking rules in LogEntryDataMaskRule__mdt, added several new *Truncation__c fields (like LogEntry__c.HttpRequestBodyTruncated__c & LogEntry__c.HttpResponseBodyTruncated__c), and fixed issues with string truncation to ensure the value is properly truncated after data masking has occurred.",
+      "versionNumber": "4.16.2.NEXT",
+      "versionName": "Origin Location Parsing Improvements",
+      "versionDescription": "Tweaked how origin location is parsed when External entry point is the first line of a stack trace",
       "postInstallUrl": "https://github.com/jongpie/NebulaLogger/wiki",
       "releaseNotesUrl": "https://github.com/jongpie/NebulaLogger/releases",
       "unpackagedMetadata": {
@@ -217,6 +217,7 @@
     "Nebula Logger - Core@4.15.10-approval-logging": "04t5Y0000015pGeQAI",
     "Nebula Logger - Core@4.16.0-spring-'25-release": "04t5Y0000015pGyQAI",
     "Nebula Logger - Core@4.16.1-data-masking-&-string-truncation-improvements": "04tKe0000011MXEIA2",
+    "Nebula Logger - Core@4.16.2-origin-location-parsing-improvements": "04tKe0000011Mi9IAE",
     "Nebula Logger - Core Plugin - Async Failure Additions": "0Ho5Y000000blO4SAI",
     "Nebula Logger - Core Plugin - Async Failure Additions@1.0.0": "04t5Y0000015lhiQAA",
     "Nebula Logger - Core Plugin - Async Failure Additions@1.0.1": "04t5Y0000015lhsQAA",