Fix UpdateFailed for transient auth errors, simplify sensor class hierarchy

- api.py: raise UpdateFailed (not ConfigEntryNotReady) for transient
  OAuth token errors so the coordinator can handle them gracefully
  during periodic updates
- sensor.py: remove intermediate EveOnlineSensor base class; move
  native_value and entity_description directly into EveOnlineCharacterSensor
- conftest.py: fix Generator return type annotation to full form
  Generator[AsyncMock, None, None] for strict mypy compliance
- test_api.py: update assertions to expect UpdateFailed instead of
  ConfigEntryNotReady for transient errors

Author: ronaldvdmeer

homeassistant/components/eveonline/api.py

@@ -9,11 +9,11 @@
 
 from homeassistant.exceptions import (
     ConfigEntryAuthFailed,
-    ConfigEntryNotReady,
     OAuth2TokenRequestReauthError,
     OAuth2TokenRequestTransientError,
 )
 from homeassistant.helpers.config_entry_oauth2_flow import OAuth2Session
+from homeassistant.helpers.update_coordinator import UpdateFailed
 
 from .const import DOMAIN
 
@@ -40,7 +40,7 @@ async def async_get_access_token(self) -> str:
                 translation_key="authentication_failed",
             ) from err
         except (OAuth2TokenRequestTransientError, ClientError) as err:
-            raise ConfigEntryNotReady(
+            raise UpdateFailed(
                 translation_domain=DOMAIN,
                 translation_key="token_refresh_failed",
                 translation_placeholders={"error": str(err)},

homeassistant/components/eveonline/sensor.py

@@ -164,20 +164,10 @@ async def async_setup_entry(
     )
 
 
-class EveOnlineSensor(SensorEntity):
-    """Base class for Eve Online sensors."""
+class EveOnlineCharacterSensor(EveOnlineCharacterEntity, SensorEntity):
+    """Eve Online character sensor (per-character device)."""
 
     entity_description: EveOnlineSensorDescription
-    coordinator: EveOnlineCoordinator
-
-    @property
-    def native_value(self) -> str | int | float | datetime | None:
-        """Return the sensor value."""
-        return self.entity_description.value_fn(self.coordinator.data)
-
-
-class EveOnlineCharacterSensor(EveOnlineCharacterEntity, EveOnlineSensor):
-    """Eve Online character sensor (per-character device)."""
 
     def __init__(
         self,
@@ -187,3 +177,8 @@ def __init__(
         """Initialize the sensor."""
         super().__init__(coordinator, description.key)
         self.entity_description = description
+
+    @property
+    def native_value(self) -> str | int | float | datetime | None:
+        """Return the sensor value."""
+        return self.entity_description.value_fn(self.coordinator.data)

tests/components/eveonline/test_api.py

@@ -9,10 +9,10 @@
 from homeassistant.components.eveonline.const import DOMAIN
 from homeassistant.exceptions import (
     ConfigEntryAuthFailed,
-    ConfigEntryNotReady,
     OAuth2TokenRequestReauthError,
     OAuth2TokenRequestTransientError,
 )
+from homeassistant.helpers.update_coordinator import UpdateFailed
 
 
 def _make_auth(
@@ -43,16 +43,16 @@ async def test_get_access_token_reauth_error() -> None:
 
 
 async def test_get_access_token_transient_error() -> None:
-    """Test that OAuth2TokenRequestTransientError raises ConfigEntryNotReady."""
+    """Test that OAuth2TokenRequestTransientError raises UpdateFailed."""
     auth = _make_auth(
         OAuth2TokenRequestTransientError(domain=DOMAIN, request_info=Mock())
     )
-    with pytest.raises(ConfigEntryNotReady):
+    with pytest.raises(UpdateFailed):
         await auth.async_get_access_token()
 
 
 async def test_get_access_token_client_error() -> None:
-    """Test that aiohttp.ClientError raises ConfigEntryNotReady."""
+    """Test that aiohttp.ClientError raises UpdateFailed."""
     auth = _make_auth(aiohttp.ClientError("network"))
-    with pytest.raises(ConfigEntryNotReady):
+    with pytest.raises(UpdateFailed):
         await auth.async_get_access_token()