From b84afb5753c50e26c8c1e81061a81316dbff6638 Mon Sep 17 00:00:00 2001 From: Jens Rantil Date: Fri, 22 Mar 2019 20:27:32 +0100 Subject: [PATCH] ref(memberlist): take read lock when only reading Likely not super important commit, but nice for clarity, I guess. --- memberlist.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/memberlist.go b/memberlist.go index f289a12ae..bb4a663a7 100644 --- a/memberlist.go +++ b/memberlist.go @@ -571,9 +571,9 @@ func (m *Memberlist) Leave(timeout time.Duration) error { if !m.hasLeft() { atomic.StoreInt32(&m.leave, 1) - m.nodeLock.Lock() + m.nodeLock.RLock() state, ok := m.nodeMap[m.config.Name] - m.nodeLock.Unlock() + m.nodeLock.RUnlock() if !ok { m.logger.Printf("[WARN] memberlist: Leave but we're not in the node map.") return nil