From fe7621dea2efe457842eecf6a8885be293e6665b Mon Sep 17 00:00:00 2001
From: nu774 <honeycomb77@gmail.com>
Date: Fri, 3 Mar 2023 11:40:43 +0900
Subject: [PATCH 1/2] Fix: trickle ICE signaling was not working at all

Properly send each ICE candidate to Ayame as defined in the Ayame spec.
---
 ayame/connection.go | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/ayame/connection.go b/ayame/connection.go
index df74bdc..55b53b4 100644
--- a/ayame/connection.go
+++ b/ayame/connection.go
@@ -358,6 +358,17 @@ func (c *Connection) createPeerConnection() error {
 			}
 		}()
 	})
+	pc.OnICECandidate(func(candidate *webrtc.ICECandidate) {
+		if candidate != nil {
+			json := candidate.ToJSON()
+			c.trace("ICE candidate: %v", json)
+			msg := candidateMessage{
+				Type:         "candidate",
+				ICECandidate: &json,
+			}
+			c.sendMsg(msg)
+		}
+	})
 	// Set the Handler for ICE connection state
 	// This will notify you when the peer has connected/disconnected
 	pc.OnICEConnectionStateChange(func(connectionState webrtc.ICEConnectionState) {

From 66a349ec8f60dc1fb9ba0d4a3a0a1b2677e58053 Mon Sep 17 00:00:00 2001
From: nu774 <honeycomb77@gmail.com>
Date: Tue, 7 Mar 2023 09:42:38 +0900
Subject: [PATCH 2/2] fix: OnDisconnect() doesn't work at all

since Disconnect() clears onDisconnectHandler, onDisconnectHandler
has to be called before Disconnect()
---
 ayame/connection.go | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/ayame/connection.go b/ayame/connection.go
index 55b53b4..9cb83cd 100644
--- a/ayame/connection.go
+++ b/ayame/connection.go
@@ -346,8 +346,8 @@ func (c *Connection) createPeerConnection() error {
 						return
 					}
 					c.trace("read RTP error %v", readErr)
-					c.Disconnect()
 					c.onDisconnectHandler("READ-RTP-ERROR", err)
+					c.Disconnect()
 					return
 				}
 				c.onTrackPacketHandler(track, rtp)
@@ -382,8 +382,8 @@ func (c *Connection) createPeerConnection() error {
 			case webrtc.ICEConnectionStateDisconnected:
 				fallthrough
 			case webrtc.ICEConnectionStateFailed:
-				c.Disconnect()
 				c.onDisconnectHandler("ICE-CONNECTION-STATE-FAILED", nil)
+				c.Disconnect()
 			}
 		}
 	})
@@ -430,8 +430,8 @@ func (c *Connection) createAnswer() error {
 
 	answer, err := c.pc.CreateAnswer(nil)
 	if err != nil {
-		c.Disconnect()
 		c.onDisconnectHandler("CREATE-ANSWER-ERROR", err)
+		c.Disconnect()
 		return err
 	}
 	c.trace("create answer sdp=%s", answer.SDP)
@@ -460,8 +460,8 @@ func (c *Connection) setOffer(sessionDescription webrtc.SessionDescription) erro
 	}
 	err := c.pc.SetRemoteDescription(sessionDescription)
 	if err != nil {
-		c.Disconnect()
 		c.onDisconnectHandler("CREATE-OFFER-ERROR", err)
+		c.Disconnect()
 		return err
 	}
 	c.trace("set offer sdp=%s", sessionDescription.SDP)
@@ -616,8 +616,8 @@ loop:
 	c.trace("CLOSE-MESSAGE-CHANNEL")
 	<-ctx.Done()
 	c.trace("EXITED-MAIN")
-	c.Disconnect()
 	c.onDisconnectHandler("EXIT-RECV", nil)
+	c.Disconnect()
 	c.trace("EXIT-RECV")
 }
 
@@ -675,8 +675,8 @@ func (c *Connection) handleMessage(rawMessage []byte) error {
 		if rejectReason == "" {
 			rejectReason = "REJECTED"
 		}
-		c.Disconnect()
 		c.onDisconnectHandler(rejectReason, nil)
+		c.Disconnect()
 	case "offer":
 		offerMsg := webrtc.SessionDescription{}
 		if err := unmarshalMessage(c, rawMessage, &offerMsg); err != nil {