Inline all plain text attachments

Not only patches.

Author: AndersAstrand

app/models/attachment.rb

@@ -5,6 +5,25 @@ class Attachment < ApplicationRecord
   after_create :mark_topic_has_attachments
   after_destroy :update_topic_has_attachments
 
+  # This list is in no way comprehensive. It can be extended as needed.
+  TEXT_APPLICATION_TYPES = %w[
+    application/json
+    application/sql
+    application/x-perl
+    application/x-python
+    application/x-ruby
+    application/x-sh
+    application/x-shellscript
+    application/xml
+    application/yaml
+  ].freeze
+
+  def text?
+    return true if content_type&.start_with?('text/')
+    return true if content_type&.end_with?('+xml', '+json')
+    TEXT_APPLICATION_TYPES.include?(content_type)
+  end
+
   def patch?
     patch_extension? || patch_content?
   end

app/views/topics/_message.html.slim

@@ -80,6 +80,16 @@
               pre.attachment-content
                 code.language-diff data-controller="diff-highlight"
                   = attachment.decoded_body_utf8
+          - elsif attachment.text?
+            details.attachment
+              summary.attachment-info
+                span.attachment-summary-row
+                  span.filename = attachment.file_name
+                  span.content-type = attachment.content_type if attachment.content_type
+                  = link_to "Download", attachment_path(attachment), class: "attachment-download", download: attachment.file_name, data: { turbo: false }
+              pre.attachment-content
+                code
+                  = attachment.decoded_body_utf8
           - else
             .attachment
               .attachment-info