Skip to content

Commit 72130c5

Browse files
authored
Use PORT env variable instead of hardcoded value (#74)
1 parent d19dd5f commit 72130c5

4 files changed

Lines changed: 6 additions & 4 deletions

File tree

.env.development.example

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,8 @@ PGPORT=5432
1010
PGDATABASE=${POSTGRES_DB}
1111
SECRET_KEY_BASE=dev-secret-change-me
1212

13+
PORT=3000
14+
1315
# Optional IMAP (used when running the imap_worker profile)
1416
IMAP_USERNAME=your-imap-username
1517
IMAP_PASSWORD=your-imap-password

Dockerfile.dev

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,4 +22,4 @@ RUN npm install
2222
EXPOSE 3000
2323

2424
ENTRYPOINT ["./bin/docker-entrypoint"]
25-
CMD ["./bin/rails", "server", "-b", "0.0.0.0", "-p", "3000"]
25+
CMD ["./bin/rails", "server", "-b", "0.0.0.0"]

Makefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
COMPOSE ?= docker compose -f docker-compose.dev.yml
1+
COMPOSE ?= docker compose --env-file .env.development -f docker-compose.dev.yml
22

33
.PHONY: dev dev-detach down shell console test imap logs db-migrate db-reset db-import stats psql sim-email-once sim-email-stream
44

docker-compose.dev.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ services:
3131
RAILS_ENV: ${RAILS_ENV:-development}
3232
NODE_ENV: ${NODE_ENV:-development}
3333
HOST: 0.0.0.0
34-
PORT: 3000
34+
PORT: ${PORT:-3000}
3535
DATABASE_URL: ${DATABASE_URL:-postgresql://${POSTGRES_USER:-hackorum}:${POSTGRES_PASSWORD:-hackorum}@db:5432/${POSTGRES_DB:-hackorum_development}}
3636
PGHOST: db
3737
PGPORT: 5432
@@ -45,7 +45,7 @@ services:
4545
- bundle:/usr/local/bundle
4646
- node_modules:/app/node_modules
4747
ports:
48-
- "3000:3000"
48+
- "${PORT:-3000}:${PORT:-3000}"
4949
depends_on:
5050
db:
5151
condition: service_healthy

0 commit comments

Comments
 (0)