[rubocop] Fix all rubocop offenses

Author: moozzi

app/controllers/activities_controller.rb

@@ -7,7 +7,7 @@ def index
     @search_query = params[:q].to_s.strip
     @activities = base_scope
                     .then { |scope| apply_query(scope) }
-                    .includes(subject: [:topic, { message: :sender }])
+                    .includes(subject: [ :topic, { message: :sender } ])
                     .order(created_at: :desc)
                     .limit(100)
     mark_shown_as_read!(@activities)

app/controllers/admin/base_controller.rb

@@ -1,7 +1,7 @@
 # frozen_string_literal: true
 
 class Admin::BaseController < ApplicationController
-  layout 'admin'
+  layout "admin"
 
   before_action :require_admin
 

app/controllers/admin/imap_sync_states_controller.rb

@@ -21,4 +21,3 @@ def index
     end
   end
 end
-

app/controllers/admin/users_controller.rb

@@ -1,15 +1,15 @@
 # frozen_string_literal: true
 
 class Admin::UsersController < Admin::BaseController
-  before_action :set_user, only: [:toggle_admin, :new_email, :confirm_email, :add_email]
+  before_action :set_user, only: [ :toggle_admin, :new_email, :confirm_email, :add_email ]
 
   def active_admin_section
     :users
   end
 
   def index
     @users = User.active
-                 .includes(person: [:default_alias, :aliases])
+                 .includes(person: [ :default_alias, :aliases ])
                  .order(created_at: :desc)
                  .limit(params.fetch(:limit, 50).to_i)
                  .offset(params.fetch(:offset, 0).to_i)
@@ -34,7 +34,7 @@ def confirm_email
     end
 
     @existing_aliases = Alias.by_email(@email)
-    @owned_by_other = @existing_aliases.where.not(user_id: [nil, @user.id]).exists?
+    @owned_by_other = @existing_aliases.where.not(user_id: [ nil, @user.id ]).exists?
   end
 
   def add_email
@@ -48,7 +48,7 @@ def add_email
 
     aliases = Alias.by_email(email)
 
-    if aliases.where.not(user_id: [nil, @user.id]).exists?
+    if aliases.where.not(user_id: [ nil, @user.id ]).exists?
       return redirect_to admin_users_path, alert: "Email is linked to another account. Cannot associate."
     end
 

app/controllers/application_controller.rb

@@ -8,9 +8,9 @@ class ApplicationController < ActionController::Base
   before_action :authorize_mini_profiler
 
   private
-  
+
   def render_404
-    render file: Rails.root.join('public', '404.html'), status: :not_found, layout: false
+    render file: Rails.root.join("public", "404.html"), status: :not_found, layout: false
   end
 
   def current_user
@@ -28,7 +28,7 @@ def current_admin?
   end
 
   def require_authentication
-    redirect_to new_session_path, alert: 'Please sign in' unless user_signed_in?
+    redirect_to new_session_path, alert: "Please sign in" unless user_signed_in?
   end
 
   def authorize_mini_profiler

app/controllers/attachments_controller.rb

@@ -10,4 +10,3 @@ def show
     send_data data, filename: filename, type: content_type, disposition: "attachment"
   end
 end
-

app/controllers/concerns/profile_activity.rb

@@ -177,7 +177,7 @@ def compute_activity_types(message:, topic:, first_message_per_topic:, first_pat
 
   def build_contribution_weeks(year, filters: nil)
     ids = person_ids_for_query
-    return [[], []] if ids.blank?
+    return [ [], [] ] if ids.blank?
 
     year = year.to_i
     wday_start = @week_start_day || WeekCalculation::DEFAULT_WEEK_START
@@ -208,7 +208,7 @@ def build_contribution_weeks(year, filters: nil)
     end
 
     month_spans = build_month_spans(weeks_data)
-    [weeks_data, month_spans]
+    [ weeks_data, month_spans ]
   end
 
   def build_month_spans(weeks_data)
@@ -218,10 +218,10 @@ def build_month_spans(weeks_data)
 
     weeks_data.each do |week|
       first_date = week[:days].first[:date]
-      month_key = [first_date.year, first_date.month]
+      month_key = [ first_date.year, first_date.month ]
       if current_month != month_key
         if current_month
-          month_spans << { label: Date.new(current_month[0], current_month[1], 1).strftime('%b'), year: current_month[0], month: current_month[1], span: current_span }
+          month_spans << { label: Date.new(current_month[0], current_month[1], 1).strftime("%b"), year: current_month[0], month: current_month[1], span: current_span }
         end
         current_month = month_key
         current_span = 1
@@ -230,7 +230,7 @@ def build_month_spans(weeks_data)
       end
     end
 
-    month_spans << { label: Date.new(current_month[0], current_month[1], 1).strftime('%b'), year: current_month[0], month: current_month[1], span: current_span } if current_month
+    month_spans << { label: Date.new(current_month[0], current_month[1], 1).strftime("%b"), year: current_month[0], month: current_month[1], span: current_span } if current_month
     month_spans
   end
 

app/controllers/help_controller.rb

@@ -6,7 +6,7 @@ class HelpController < ApplicationController
   PAGES = {
     "search" => "Advanced Search Guide",
     "hackorum-patch" => "Applying Patches with hackorum-patch",
-    "account-linking" => "Account Linking & Multiple Emails",
+    "account-linking" => "Account Linking & Multiple Emails"
   }.freeze
 
   def index

app/controllers/messages_controller.rb

@@ -1,11 +1,11 @@
 # frozen_string_literal: true
 
 class MessagesController < ApplicationController
-  before_action :require_authentication, only: [:read]
+  before_action :require_authentication, only: [ :read ]
 
   def by_message_id
     raw = params[:message_id].to_s
-    decoded = CGI.unescape(raw.gsub('+', '%2B'))
+    decoded = CGI.unescape(raw.gsub("+", "%2B"))
     message = Message.find_by(message_id: decoded)
 
     if message

app/controllers/notes_controller.rb

@@ -2,7 +2,7 @@
 
 class NotesController < ApplicationController
   before_action :require_authentication
-  before_action :set_note, only: [:update, :destroy]
+  before_action :set_note, only: [ :update, :destroy ]
 
   def create
     topic = Topic.find(note_params[:topic_id])
@@ -62,7 +62,7 @@ def set_note
     end
     unless @note.author_id == current_user.id
       redirect_back fallback_location: topic_path(@note.topic), alert: "You can edit or delete your own notes"
-      return
+      nil
     end
   end