Add easy hide/delete buttons to the saved search sidebar

Author: dutow

app/assets/stylesheets/components/sidebar.css

@@ -210,6 +210,52 @@
   }
 }
 
+.sidebar .quick-filters li {
+  display: flex;
+  align-items: center;
+}
+
+.sidebar .quick-filters li a {
+  flex: 1;
+  min-width: 0;
+}
+
+.sidebar .quick-filter-action-form {
+  flex-shrink: 0;
+  line-height: 1;
+  opacity: 0;
+  transition: opacity var(--transition-fast);
+}
+
+.sidebar .quick-filters li:hover .quick-filter-action-form,
+.sidebar .quick-filter-action-form:focus-within {
+  opacity: 1;
+}
+
+.sidebar .quick-filter-action-form button {
+  appearance: none;
+  background: var(--color-bg-button);
+  color: var(--color-text-button);
+  border: var(--border-width) solid var(--color-border);
+  border-radius: var(--border-radius-md);
+  cursor: pointer;
+  padding: var(--spacing-1) var(--spacing-2);
+  font-size: var(--font-size-xs);
+  line-height: 1;
+  transition: background var(--transition-fast), border-color var(--transition-fast);
+}
+
+.sidebar .quick-filter-action-form button:hover {
+  background: var(--color-bg-button-hover);
+  border-color: var(--color-primary-300);
+}
+
+@media (hover: none) {
+  .sidebar .quick-filter-action-form {
+    opacity: 1;
+  }
+}
+
 .sidebar .tags-list {
   padding-left: var(--spacing-3);
 }

app/controllers/settings/saved_search_preferences_controller.rb

@@ -3,7 +3,7 @@
 module Settings
   class SavedSearchPreferencesController < Settings::BaseController
     def create
-      saved_search = SavedSearch.find(params[:saved_search_id])
+      saved_search = SavedSearch.visible_to(current_user).find(params[:saved_search_id])
       hidden = ActiveModel::Type::Boolean.new.cast(params[:hidden])
 
       pref = SavedSearchPreference.find_or_initialize_by(

app/controllers/settings/saved_searches_controller.rb

@@ -47,7 +47,7 @@ def update
 
     def destroy
       @saved_search.destroy
-      redirect_to settings_saved_searches_path, notice: "Saved search deleted"
+      redirect_back fallback_location: settings_saved_searches_path, notice: "Saved search deleted"
     end
 
     private

app/views/topics/_sidebar.html.slim

@@ -36,7 +36,10 @@
               span.filter-subsection-label Global
               ul.quick-filters
                 - global_searches.each do |ss|
-                  li = link_to ss.name, search_topics_path(saved_search_id: ss.id), class: ("quick-filter-link is-active" if active_ss_id == ss.id)
+                  li
+                    = link_to ss.name, search_topics_path(saved_search_id: ss.id), class: ("quick-filter-link is-active" if active_ss_id == ss.id)
+                    = button_to settings_saved_search_preferences_path(saved_search_id: ss.id, hidden: true), method: :post, form_class: "quick-filter-action-form", data: { turbo_confirm: "Hide this search?" } do
+                      i.fa-solid.fa-eye-slash aria-hidden="true"
 
           - if user_signed_in?
             - user_searches = @saved_searches.select { |ss| ss.scope_user? && ss.user_id.present? }
@@ -47,7 +50,14 @@
                 span.filter-subsection-label My searches
                 ul.quick-filters
                   - all_user.each do |ss|
-                    li = link_to ss.name, search_topics_path(saved_search_id: ss.id), class: ("quick-filter-link is-active" if active_ss_id == ss.id)
+                    li
+                      = link_to ss.name, search_topics_path(saved_search_id: ss.id), class: ("quick-filter-link is-active" if active_ss_id == ss.id)
+                      - if ss.user_id == current_user.id
+                        = button_to settings_saved_search_path(ss), method: :delete, form_class: "quick-filter-action-form", data: { turbo_confirm: "Delete this search?" } do
+                          i.fa-solid.fa-trash-can aria-hidden="true"
+                      - else
+                        = button_to settings_saved_search_preferences_path(saved_search_id: ss.id, hidden: true), method: :post, form_class: "quick-filter-action-form", data: { turbo_confirm: "Hide this search?" } do
+                          i.fa-solid.fa-eye-slash aria-hidden="true"
 
             - team_templates = @saved_searches.select { |ss| ss.scope_team? && ss.team_id.nil? }
             - team_specific = @saved_searches.select { |ss| ss.scope_team? && ss.team_id.present? }
@@ -59,7 +69,10 @@
                   span.filter-subsection-label = "#{team.name} searches"
                   ul.quick-filters
                     - all_team.each do |ss|
-                      li = link_to ss.name, search_topics_path(saved_search_id: ss.id, team_id: team.id), class: ("quick-filter-link is-active" if active_ss_id == ss.id && (!ss.scope_team? || active_team_id == team.id))
+                      li
+                        = link_to ss.name, search_topics_path(saved_search_id: ss.id, team_id: team.id), class: ("quick-filter-link is-active" if active_ss_id == ss.id && (!ss.scope_team? || active_team_id == team.id))
+                        = button_to settings_saved_search_preferences_path(saved_search_id: ss.id, hidden: true), method: :post, form_class: "quick-filter-action-form", data: { turbo_confirm: "Hide this search?" } do
+                          i.fa-solid.fa-eye-slash aria-hidden="true"
 
     - if user_signed_in? && @available_note_tags.present?
       .sidebar-section

spec/requests/settings/saved_search_preferences_spec.rb

@@ -38,6 +38,47 @@ def sign_in(user)
       expect(pref.reload.hidden).to be false
     end
 
+    it "hides a team-specific saved search for a team member" do
+      user = create(:user)
+      team = create(:team)
+      create(:team_member, team: team, user: user)
+      saved_search = create(:saved_search, scope: "team", team: team)
+      sign_in(user)
+
+      expect {
+        post settings_saved_search_preferences_path, params: { saved_search_id: saved_search.id, hidden: true }
+      }.to change(SavedSearchPreference, :count).by(1)
+
+      pref = SavedSearchPreference.last
+      expect(pref.hidden).to be true
+    end
+
+    it "hides a team template saved search" do
+      user = create(:user)
+      saved_search = create(:saved_search, scope: "team", team: nil)
+      sign_in(user)
+
+      expect {
+        post settings_saved_search_preferences_path, params: { saved_search_id: saved_search.id, hidden: true }
+      }.to change(SavedSearchPreference, :count).by(1)
+
+      pref = SavedSearchPreference.last
+      expect(pref.hidden).to be true
+    end
+
+    it "rejects hiding a search not visible to the user" do
+      user = create(:user)
+      other_user = create(:user)
+      saved_search = create(:saved_search, scope: "user", user: other_user)
+      sign_in(user)
+
+      expect {
+        post settings_saved_search_preferences_path, params: { saved_search_id: saved_search.id, hidden: true }
+      }.not_to change(SavedSearchPreference, :count)
+
+      expect(response).to have_http_status(:not_found)
+    end
+
     it "redirects guests to new_session_path" do
       saved_search = create(:saved_search)