Skip to content

Commit ae0f0ef

Browse files
fix: logic to suppress failed metric export during client shutdown (#2858)
Otel will try to do a final export when its shutting down, however that request can be rejected by the monitoring api due to rate limits. So previously we added an option to suppress the scary log warning. Unfortunately it had a logic bug that prevented it from working. This fixes it Change-Id: Id62af7fadc8beea41f5bfd011f7bc7c0899198ab Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly: - [ ] Make sure to open an issue as a [bug/issue](https://togithub.com/googleapis/java-bigtable/issues/new/choose) before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea - [ ] Ensure the tests and linter pass - [ ] Code coverage does not decrease (if any source code was changed) - [ ] Appropriate docs were updated (if necessary) - [ ] Rollback plan is reviewed and LGTMed - [ ] All new data plane features have a completed end to end testing plan Fixes #<issue_number_goes_here> ☕️ If you write sample code, please follow the [samples format]( https://togithub.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
1 parent c2ccda1 commit ae0f0ef

1 file changed

Lines changed: 1 addition & 1 deletion

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/internal/csm/exporter/BigtableCloudMonitoringExporter.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -194,7 +194,7 @@ public void onFailure(Throwable throwable) {
194194
RuntimeException asyncWrapper = new RuntimeException("export failed", throwable);
195195
asyncWrapper.setStackTrace(stackTrace);
196196

197-
if (state.get() != State.Closing || state.get() != State.Closed) {
197+
if (state.get() != State.Closing && state.get() != State.Closed) {
198198
// ignore the export warning when client is shutting down
199199
LOGGER.log(Level.WARNING, msg, asyncWrapper);
200200
}

0 commit comments

Comments
 (0)