Skip to content

Commit 17cde56

Browse files
committed
fix: move batch metrics to internal views
1 parent b3cadab commit 17cde56

1 file changed

Lines changed: 17 additions & 17 deletions

File tree

google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/BuiltinMetricsConstants.java

Lines changed: 17 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -279,6 +279,23 @@ public static Map<InstrumentSelector, View> getInternalViews() {
279279
ImmutableSet.<AttributeKey>builder()
280280
.add(BIGTABLE_PROJECT_ID_KEY, INSTANCE_ID_KEY, APP_PROFILE_KEY, CLIENT_NAME_KEY)
281281
.build());
282+
defineView(
283+
views,
284+
BATCH_WRITE_FLOW_CONTROL_TARGET_QPS_NAME,
285+
null,
286+
InstrumentType.GAUGE,
287+
"1",
288+
ImmutableSet.<AttributeKey>builder().addAll(COMMON_ATTRIBUTES).build());
289+
defineView(
290+
views,
291+
BATCH_WRITE_FLOW_CONTROL_FACTOR_NAME,
292+
AGGREGATION_BATCH_WRITE_FLOW_CONTROL_FACTOR_HISTOGRAM,
293+
InstrumentType.HISTOGRAM,
294+
"1",
295+
ImmutableSet.<AttributeKey>builder()
296+
.addAll(COMMON_ATTRIBUTES)
297+
.add(STATUS_KEY, APPLIED_KEY)
298+
.build());
282299
return views.build();
283300
}
284301

@@ -373,23 +390,6 @@ public static Map<InstrumentSelector, View> getAllViews() {
373390
.addAll(COMMON_ATTRIBUTES)
374391
.add(STREAMING_KEY, STATUS_KEY)
375392
.build());
376-
defineView(
377-
views,
378-
BATCH_WRITE_FLOW_CONTROL_TARGET_QPS_NAME,
379-
null,
380-
InstrumentType.GAUGE,
381-
"1",
382-
ImmutableSet.<AttributeKey>builder().addAll(COMMON_ATTRIBUTES).build());
383-
defineView(
384-
views,
385-
BATCH_WRITE_FLOW_CONTROL_FACTOR_NAME,
386-
AGGREGATION_BATCH_WRITE_FLOW_CONTROL_FACTOR_HISTOGRAM,
387-
InstrumentType.HISTOGRAM,
388-
"1",
389-
ImmutableSet.<AttributeKey>builder()
390-
.addAll(COMMON_ATTRIBUTES)
391-
.add(STATUS_KEY, APPLIED_KEY)
392-
.build());
393393
return views.build();
394394
}
395395
}

0 commit comments

Comments
 (0)