chore: complete google-cloud-dns migration (#16678)

- Reformat with nox
- Enable generation with librarian
- Regenerate with librarian

Author: jskeet

librarian.yaml

@@ -1881,7 +1881,6 @@ libraries:
   - name: google-cloud-dns
     version: 0.36.1
     description_override: provides methods that you can use to manage DNS for your applications.
-    skip_generate: true
     python:
       library_type: REST
       name_pretty_override: Cloud DNS

packages/google-cloud-dns/.repo-metadata.json

@@ -1,17 +1,13 @@
 {
-    "name": "dns",
-    "name_pretty": "Cloud DNS",
-    "product_documentation": "https://cloud.google.com/dns",
+    "api_shortname": "dns",
     "client_documentation": "https://cloud.google.com/python/docs/reference/dns/latest",
+    "distribution_name": "google-cloud-dns",
     "issue_tracker": "https://issuetracker.google.com/savedsearches/559772",
-    "release_level": "preview",
     "language": "python",
     "library_type": "REST",
-    "repo": "googleapis/google-cloud-python",
-    "distribution_name": "google-cloud-dns",
-    "requires_billing": true,
-    "default_version": "",
-    "codeowner_team": "",
-    "api_shortname": "dns",
-    "api_description": "provides methods that you can use to manage DNS for your applications."
-}
+    "name": "dns",
+    "name_pretty": "Cloud DNS",
+    "product_documentation": "https://cloud.google.com/dns",
+    "release_level": "preview",
+    "repo": "googleapis/google-cloud-python"
+}

packages/google-cloud-dns/docs/conf.py

@@ -24,9 +24,9 @@
 # All configuration values have a default; values that are commented out
 # serve to show the default.
 
-import sys
 import os
 import shlex
+import sys
 
 # If extensions (or modules to document with autodoc) are in another directory,
 # add these directories to sys.path here. If the directory is relative to the

packages/google-cloud-dns/google/cloud/dns/__init__.py

@@ -24,12 +24,13 @@
   (adding/deleting resource record sets) to a zone.
 """
 
-from google.cloud.dns.version import __version__
-from google.cloud.dns.zone import Changes
+from google.cloud.dns import version
+
+__version__ = version.__version__
+
 from google.cloud.dns.client import Client
-from google.cloud.dns.zone import ManagedZone
 from google.cloud.dns.resource_record_set import ResourceRecordSet
-
+from google.cloud.dns.zone import Changes, ManagedZone
 
 SCOPE = Client.SCOPE
 

packages/google-cloud-dns/google/cloud/dns/_http.py

@@ -15,7 +15,6 @@
 """Create / interact with Google Cloud DNS connections."""
 
 from google.cloud import _http
-
 from google.cloud.dns import __version__
 
 

packages/google-cloud-dns/google/cloud/dns/changes.py

@@ -16,6 +16,7 @@
 
 from google.cloud._helpers import _rfc3339_to_datetime
 from google.cloud.exceptions import NotFound
+
 from google.cloud.dns.resource_record_set import ResourceRecordSet
 
 

packages/google-cloud-dns/google/cloud/dns/client.py

@@ -14,8 +14,8 @@
 
 """Client for interacting with the Google Cloud DNS API."""
 
-from google.api_core import page_iterator
 from google.api_core import client_options as client_options_mod
+from google.api_core import page_iterator
 from google.cloud.client import ClientWithProject
 
 from google.cloud.dns._http import Connection

packages/google-cloud-dns/google/cloud/dns/zone.py

@@ -17,6 +17,7 @@
 from google.api_core import page_iterator
 from google.cloud._helpers import _rfc3339_to_datetime
 from google.cloud.exceptions import NotFound
+
 from google.cloud.dns.changes import Changes
 from google.cloud.dns.resource_record_set import ResourceRecordSet
 

packages/google-cloud-dns/setup.py

@@ -18,7 +18,6 @@
 
 import setuptools
 
-
 # Package metadata.
 
 name = "google-cloud-dns"

packages/google-cloud-dns/tests/unit/test__http.py

@@ -28,8 +28,7 @@ def _make_one(self, *args, **kw):
         return self._get_target_class()(*args, **kw)
 
     def test_build_api_url_no_extra_query_params(self):
-        from urllib.parse import parse_qsl
-        from urllib.parse import urlsplit
+        from urllib.parse import parse_qsl, urlsplit
 
         conn = self._make_one(object())
         uri = conn.build_api_url("/foo")
@@ -42,8 +41,7 @@ def test_build_api_url_no_extra_query_params(self):
         self.assertEqual(parms, {})
 
     def test_build_api_url_w_custom_endpoint(self):
-        from urllib.parse import parse_qsl
-        from urllib.parse import urlsplit
+        from urllib.parse import parse_qsl, urlsplit
 
         custom_endpoint = "https://foo-dns.googleapis.com"
         conn = self._make_one(object(), api_endpoint=custom_endpoint)
@@ -57,8 +55,7 @@ def test_build_api_url_w_custom_endpoint(self):
         self.assertEqual(parms, {})
 
     def test_build_api_url_w_extra_query_params(self):
-        from urllib.parse import parse_qsl
-        from urllib.parse import urlsplit
+        from urllib.parse import parse_qsl, urlsplit
 
         conn = self._make_one(object())
         uri = conn.build_api_url("/foo", {"bar": "baz"})
@@ -70,6 +67,7 @@ def test_build_api_url_w_extra_query_params(self):
 
     def test_extra_headers(self):
         import requests
+
         from google.cloud import _http as base_http
 
         http = mock.create_autospec(requests.Session, instance=True)