Skip to content

chore: Make _pytrial_parameters public in StudyConfig. #1303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
May 27, 2026
+8 −8
Merged

chore: Make _pytrial_parameters public in StudyConfig. #1303

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions vizier/_src/pyvizier/oss/study_config.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,9 +336,9 @@ def trial_parameters(
ValueError: If the trial contains duplicate parameters.
"""
pytrial = proto_converters.TrialConverter.from_proto(proto)
return self._pytrial_parameters(pytrial)
return self.pytrial_parameters(pytrial)

def _pytrial_parameters(
def pytrial_parameters(
self, pytrial: trial.Trial
) -> Dict[str, ParameterValueSequence]:
"""Returns the trial values, cast to external types, if they exist.
Expand Down
12 changes: 6 additions & 6 deletions vizier/_src/pyvizier/oss/study_config_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -371,7 +371,7 @@ def testPyTrialToDict(self):
'learning_rate': vz.ParameterValue(value=0.5),
'units': vz.ParameterValue(value=50),
}
parameters = py_study_config._pytrial_parameters(pytrial)
parameters = py_study_config.pytrial_parameters(pytrial)
expected = {
'learning_rate': 0.5,
'units': 50,
Expand Down Expand Up @@ -581,7 +581,7 @@ def testPyTrialToDictMultidimensional(self):
'batch_size[1]': vz.ParameterValue(value=8.0),
'floating_point_param': vz.ParameterValue(value=16.0),
}
parameters = py_study_config._pytrial_parameters(pytrial)
parameters = py_study_config.pytrial_parameters(pytrial)
expected = {
'learning_rate': [0.5, 0.1],
'units': [50, 200],
Expand Down Expand Up @@ -709,7 +709,7 @@ def testPyTrialToDictConditional(self):
'activation': vz.ParameterValue(value='relu'),
},
)
parameters = py_study_config._pytrial_parameters(pytrial)
parameters = py_study_config.pytrial_parameters(pytrial)
expected = {
'model_type': 'dnn',
'learning_rate': 2.1,
Expand Down Expand Up @@ -813,7 +813,7 @@ def testPyTrialToDictWithFinalMetricsSingleObjective(self):
steps=101,
),
)
parameters = py_study_config._pytrial_parameters(pytrial)
parameters = py_study_config.pytrial_parameters(pytrial)
self.assertEqual({'learning_rate': 0.5}, parameters)
metrics = py_study_config._pytrial_metrics(pytrial)
self.assertEqual({'objective': 77.7}, metrics)
Expand Down Expand Up @@ -904,7 +904,7 @@ def testPyTrialToDictWithFinalMetricsInfeasible(self):
steps=101,
),
)
parameters = py_study_config._pytrial_parameters(pytrial)
parameters = py_study_config.pytrial_parameters(pytrial)
self.assertEqual({'learning_rate': 0.5}, parameters)
self.assertEmpty(py_study_config._pytrial_metrics(pytrial))
self.assertEmpty(
Expand Down Expand Up @@ -978,7 +978,7 @@ def testPyTrialToDictWithFinalMetricsMultiObjective(self):
steps=101,
),
)
parameters = py_study_config._pytrial_parameters(pytrial)
parameters = py_study_config.pytrial_parameters(pytrial)
self.assertEqual({'learning_rate': 0.5}, parameters)
metrics = py_study_config._pytrial_metrics(pytrial)
self.assertEqual({'objective': 77.7, 'objective2': -0.2}, metrics)
Expand Down
Loading