feat(nvd): retry 429ed records after conversion is completed#5389
Merged
Conversation
another-rex
reviewed
May 19, 2026
Contributor
another-rex
left a comment
another-rex
left a comment
There was a problem hiding this comment.
Let's just do the first point. And rather than not setting it as invalid in the cache, set it as invalid, just with a shorter timeout than the standard 1 week. (Maybe just 1 hour is good enough, just so we are not spamming requests when multiple records relies on 1 429 host)
It'll run again in 12 hours and pick it back up.
another-rex
approved these changes
May 29, 2026
Contributor
another-rex
left a comment
another-rex
left a comment
There was a problem hiding this comment.
Probably need to update the PR description. Otherwise LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.