You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: .github/workflows/design-decision-gate.md
+1-30Lines changed: 1 addition & 30 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -23,8 +23,6 @@ safe-outputs:
23
23
- docs/adr/**
24
24
patch-format: bundle
25
25
commit-title-suffix: " [design-decision-gate]"
26
-
submit-pull-request-review:
27
-
max: 1
28
26
noop:
29
27
messages:
30
28
footer: "> 🏗️ *ADR gate enforced by [{workflow_name}]({run_url})*{effective_tokens_suffix}{history_link}"
@@ -255,18 +253,7 @@ All ADRs are stored in `docs/adr/` as Markdown files numbered by PR number (e.g.
255
253
256
254
</details>
257
255
258
-
> 🔒 *This PR has been marked as requesting changes. It cannot merge until an ADR is linked in the PR body.*
259
-
```
260
-
261
-
### Request Changes to Block Merge
262
-
263
-
Submit a pull request review with `REQUEST_CHANGES` to block the merge:
264
-
265
-
```json
266
-
{
267
-
"event": "REQUEST_CHANGES",
268
-
"body": "This PR requires an Architecture Decision Record (ADR) before it can merge. A draft ADR has been generated and committed to your branch. Please review, complete, and link it in the PR body. See the comment above for instructions."
269
-
}
256
+
> 🔒 *This PR cannot merge until an ADR is linked in the PR body.*
270
257
```
271
258
272
259
## Step 4b: If ADR Found — Verify Implementation Matches
@@ -307,14 +294,6 @@ The implementation in this PR aligns with the stated Architecture Decision Recor
307
294
The design decision has been recorded and the implementation follows it. Great work! 🏗️
308
295
```
309
296
310
-
Submit an APPROVE review:
311
-
```json
312
-
{
313
-
"event": "APPROVE",
314
-
"body": "Implementation verified: code aligns with the linked Architecture Decision Record."
315
-
}
316
-
```
317
-
318
297
**If there are DIVERGENCES**:
319
298
320
299
Post a comment describing the discrepancies:
@@ -338,14 +317,6 @@ Either:
338
317
The ADR and implementation must be in sync before this PR can merge.
339
318
```
340
319
341
-
Submit a REQUEST_CHANGES review:
342
-
```json
343
-
{
344
-
"event": "REQUEST_CHANGES",
345
-
"body": "Implementation diverges from the linked ADR. See the comment above for specific divergences. Please align the code with the ADR or update the ADR to reflect the actual decision."
346
-
}
347
-
```
348
-
349
320
## Important: Always Call a Safe Output
350
321
351
322
**You MUST always call at least one safe output tool.** If none of the above steps result in an action, call `noop` with an explanation:
0 commit comments