Skip to content

Commit 13c0272

Browse files
Copilotpelikhan
andauthored
feat(design-decision-gate): remove pull request review submissions
Remove submit-pull-request-review safe-output and all PR review submissions (REQUEST_CHANGES / APPROVE) from the design-decision-gate workflow. The gate now communicates exclusively via PR comments. Closes #25830 Agent-Logs-Url: https://github.com/github/gh-aw/sessions/468c7b5c-63ff-4f06-885e-21c32e4fcced Co-authored-by: pelikhan <4175913+pelikhan@users.noreply.github.com>
1 parent 1c7b7de commit 13c0272

File tree

2 files changed

+18
-66
lines changed

2 files changed

+18
-66
lines changed

.github/workflows/design-decision-gate.lock.yml

Lines changed: 17 additions & 36 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

.github/workflows/design-decision-gate.md

Lines changed: 1 addition & 30 deletions
Original file line numberDiff line numberDiff line change
@@ -23,8 +23,6 @@ safe-outputs:
2323
- docs/adr/**
2424
patch-format: bundle
2525
commit-title-suffix: " [design-decision-gate]"
26-
submit-pull-request-review:
27-
max: 1
2826
noop:
2927
messages:
3028
footer: "> 🏗️ *ADR gate enforced by [{workflow_name}]({run_url})*{effective_tokens_suffix}{history_link}"
@@ -255,18 +253,7 @@ All ADRs are stored in `docs/adr/` as Markdown files numbered by PR number (e.g.
255253

256254
</details>
257255

258-
> 🔒 *This PR has been marked as requesting changes. It cannot merge until an ADR is linked in the PR body.*
259-
```
260-
261-
### Request Changes to Block Merge
262-
263-
Submit a pull request review with `REQUEST_CHANGES` to block the merge:
264-
265-
```json
266-
{
267-
"event": "REQUEST_CHANGES",
268-
"body": "This PR requires an Architecture Decision Record (ADR) before it can merge. A draft ADR has been generated and committed to your branch. Please review, complete, and link it in the PR body. See the comment above for instructions."
269-
}
256+
> 🔒 *This PR cannot merge until an ADR is linked in the PR body.*
270257
```
271258

272259
## Step 4b: If ADR Found — Verify Implementation Matches
@@ -307,14 +294,6 @@ The implementation in this PR aligns with the stated Architecture Decision Recor
307294
The design decision has been recorded and the implementation follows it. Great work! 🏗️
308295
```
309296

310-
Submit an APPROVE review:
311-
```json
312-
{
313-
"event": "APPROVE",
314-
"body": "Implementation verified: code aligns with the linked Architecture Decision Record."
315-
}
316-
```
317-
318297
**If there are DIVERGENCES**:
319298

320299
Post a comment describing the discrepancies:
@@ -338,14 +317,6 @@ Either:
338317
The ADR and implementation must be in sync before this PR can merge.
339318
```
340319

341-
Submit a REQUEST_CHANGES review:
342-
```json
343-
{
344-
"event": "REQUEST_CHANGES",
345-
"body": "Implementation diverges from the linked ADR. See the comment above for specific divergences. Please align the code with the ADR or update the ADR to reflect the actual decision."
346-
}
347-
```
348-
349320
## Important: Always Call a Safe Output
350321

351322
**You MUST always call at least one safe output tool.** If none of the above steps result in an action, call `noop` with an explanation:

0 commit comments

Comments
 (0)