Ruby: don't interpret File#try_convert as a method that reads from a file/IO

alexrford · alexrford · commit ce004e9c1e42 · 2021-11-17T23:01:19.000Z
diff --git a/ruby/ql/lib/codeql/ruby/frameworks/Files.qll b/ruby/ql/lib/codeql/ruby/frameworks/Files.qll
@@ -52,9 +52,7 @@ private DataFlow::Node fileInstance() {
   )
 }
 
-private string ioReaderClassMethodName() {
-  result = ["binread", "foreach", "read", "readlines", "try_convert"]
-}
+private string ioReaderClassMethodName() { result = ["binread", "foreach", "read", "readlines"] }
 
 private string ioReaderInstanceMethodName() {
   result =

Original file line number	Diff line number	Diff line change
`@@ -52,9 +52,7 @@ private DataFlow::Node fileInstance() {`
`52`	`52`	`)`
`53`	`53`	`}`
`54`	`54`
`55`		`-private string ioReaderClassMethodName() {`
`56`		`- result = ["binread", "foreach", "read", "readlines", "try_convert"]`
`57`		`-}`
	`55`	`+private string ioReaderClassMethodName() { result = ["binread", "foreach", "read", "readlines"] }`
`58`	`56`
`59`	`57`	`private string ioReaderInstanceMethodName() {`
`60`	`58`	`result =`